From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 15 Jul 2014 21:35:12 +0200 Subject: [U-Boot] [PATCH v5] mx6: add support of multi-processor command In-Reply-To: <53C53705.3060702@huau-gabriel.fr> References: <1403375369-3882-1-git-send-email-contact@huau-gabriel.fr> <1405204264-10922-1-git-send-email-contact@huau-gabriel.fr> <53C4DCF8.9030508@denx.de> <53C53705.3060702@huau-gabriel.fr> Message-ID: <53C58270.7090802@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Gabriel, On 15/07/2014 16:13, gabriel huau wrote: >> I have just investigate a bit. The file is included by common/board_f.c >> but it is, frankly, quite not used. There are several prototype inside >> it: >> >> void setup_mp(void); >> void cpu_mp_lmb_reserve(struct lmb *lmb); >> int is_core_disabled(int nr); >> >> They are not used at all. >> >> u32 determine_mp_bootpg(unsigned int *pagesize); >> >> This is the only one that is used. >> >> Then it makes more sense to drop mp.h from board_f.c and add a prototype >> for determine_mp_bootpg(). This function is already protected by: >> >> #if defined(CONFIG_MP) && (defined(CONFIG_MPC86xx) || >> defined(CONFIG_E500)) > > I agree adding an empty is not necessary the best solution, but I'd > rather not to add any cpu/board specific defines in the common/ folder. > That's why I think we should keep CONFIG_PM as this is a generic define. > If necessary, I can propose another patch to fix it. I think we are saying the same thing. I agree letting CONFIG_MP, this is not the point. But prototype for determine_mp_bootg() can be moved in a powerpc include file and board_f does not need to include any mp.h Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================