From: Valentin Longchamp <valentin.longchamp@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] km-powerpc: define CONFIG_PRAM to protect PHRAM and PNVRAM
Date: Fri, 18 Jul 2014 11:10:23 +0200 [thread overview]
Message-ID: <53C8E47F.3020600@keymile.com> (raw)
In-Reply-To: <20140717124745.DAAD3383374@gemini.denx.de>
Hello Wolfgang,
On 07/17/2014 02:47 PM, Wolfgang Denk wrote:
> Dear Valentin,
>
> In message <1405599840-11984-1-git-send-email-valentin.longchamp@keymile.com> you wrote:
>> When u-boot initializes the RAM (early in boot) it looks for the "pram"
>> env variable to know which is area it cannot use.
>>
>> At this early boot stage, the "pram" env variable is not avaible yet
>> since it gets computed in set_km_env that gets called AFTER the RAM
>> initialization. If the "pram" env variable is not found, the default
>> CONFIG_PRAM value is used.
>
> Note that I am not objecting against this patch, but I highly
> recommend to fix your board - RAM initialization is actually pretty
> late in the init sequence, and you should have a valid envionment long
> before.
>
Maybe my commit message is unclear about this. You are right, at the RAM
initialization time, there is a valid environment, and that's the case on our
board too.
However, at the very first boot on a board, the environment is empty (or
unvalid) and the default one is used where this "pram" env variable is not
defined. That's why the CONFIG_PRAM is used in this case and it should be
defined. This is not going to be the case at any later boot if a valid
environment (with pram defined) is found and used.
Best regards,
Valentin
next prev parent reply other threads:[~2014-07-18 9:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 12:24 [U-Boot] [PATCH] km-powerpc: define CONFIG_PRAM to protect PHRAM and PNVRAM Valentin Longchamp
2014-07-17 12:47 ` Wolfgang Denk
2014-07-18 9:10 ` Valentin Longchamp [this message]
2014-08-12 18:03 ` York Sun
2014-08-13 6:13 ` Valentin Longchamp
2014-08-13 8:24 ` [U-Boot] [PATCH v2] " Valentin Longchamp
2014-08-20 19:38 ` York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C8E47F.3020600@keymile.com \
--to=valentin.longchamp@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox