public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] AHCI: Increase link timeout to 200ms
Date: Sat, 19 Jul 2014 14:33:55 +0200	[thread overview]
Message-ID: <53CA65B3.30802@redhat.com> (raw)
In-Reply-To: <1405712321-12334-1-git-send-email-ijc@hellion.org.uk>

Hi,

On 07/18/2014 09:38 PM, Ian Campbell wrote:
> In 73545f75b66d "ahci: wait longer for link" I increased the
> timeout to 40ms based on the observed behaviour of a WD disk on a
> Cubietruck. Since then Karsten Merker and myself have both
> observed timeouts with HGST disks (Karsten on Cubietruck, me on
> Cubieboard2). Increasing the timeout to ~175ms fixes this, so go
> to 200ms for a bit of headroom.
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Cc: Karsten Merker <merker@debian.org>

Looks good to me:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>   drivers/block/ahci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/ahci.c b/drivers/block/ahci.c
> index c8f6573..4df8046 100644
> --- a/drivers/block/ahci.c
> +++ b/drivers/block/ahci.c
> @@ -41,7 +41,7 @@ u16 *ataid[AHCI_MAX_PORTS];
>   #define WAIT_MS_SPINUP	20000
>   #define WAIT_MS_DATAIO	5000
>   #define WAIT_MS_FLUSH	5000
> -#define WAIT_MS_LINKUP	40
> +#define WAIT_MS_LINKUP	200
>
>   static inline u32 ahci_port_base(u32 base, u32 port)
>   {
>

  reply	other threads:[~2014-07-19 12:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18 19:38 [U-Boot] [PATCH v3 0/3] sunxi: AHCI support Ian Campbell
2014-07-18 19:38 ` [U-Boot] [PATCH 1/3] AHCI: Increase link timeout to 200ms Ian Campbell
2014-07-19 12:33   ` Hans de Goede [this message]
2014-07-19 23:22   ` Wolfgang Denk
2014-07-20  7:06     ` Ian Campbell
2014-07-22 19:24   ` [U-Boot] [U-Boot,1/3] " Tom Rini
2014-07-18 19:38 ` [U-Boot] [PATCH 2/3] board_r: run scsi init() on ARM too Ian Campbell
2014-07-19  3:12   ` Simon Glass
2014-07-21 18:23     ` Ian Campbell
2014-07-22 19:24       ` [U-Boot] [U-Boot,2/3] " Tom Rini
2014-07-18 19:38 ` [U-Boot] [PATCH 3/3] ahci: provide sunxi SATA driver using AHCI platform framework Ian Campbell
2014-07-19 12:34   ` Hans de Goede
2014-07-22 22:01   ` Tom Rini
2014-07-23  6:59     ` Ian Campbell
2014-07-23  8:14       ` Ian Campbell
2014-07-23 13:04       ` Tom Rini
2014-07-23 13:08         ` [U-Boot] [linux-sunxi] " Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CA65B3.30802@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox