From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Sat, 19 Jul 2014 14:33:55 +0200 Subject: [U-Boot] [PATCH 1/3] AHCI: Increase link timeout to 200ms In-Reply-To: <1405712321-12334-1-git-send-email-ijc@hellion.org.uk> References: <1405712297.26270.16.camel@hastur.hellion.org.uk> <1405712321-12334-1-git-send-email-ijc@hellion.org.uk> Message-ID: <53CA65B3.30802@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 07/18/2014 09:38 PM, Ian Campbell wrote: > In 73545f75b66d "ahci: wait longer for link" I increased the > timeout to 40ms based on the observed behaviour of a WD disk on a > Cubietruck. Since then Karsten Merker and myself have both > observed timeouts with HGST disks (Karsten on Cubietruck, me on > Cubieboard2). Increasing the timeout to ~175ms fixes this, so go > to 200ms for a bit of headroom. > > Signed-off-by: Ian Campbell > Cc: Karsten Merker Looks good to me: Acked-by: Hans de Goede Regards, Hans > --- > drivers/block/ahci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/ahci.c b/drivers/block/ahci.c > index c8f6573..4df8046 100644 > --- a/drivers/block/ahci.c > +++ b/drivers/block/ahci.c > @@ -41,7 +41,7 @@ u16 *ataid[AHCI_MAX_PORTS]; > #define WAIT_MS_SPINUP 20000 > #define WAIT_MS_DATAIO 5000 > #define WAIT_MS_FLUSH 5000 > -#define WAIT_MS_LINKUP 40 > +#define WAIT_MS_LINKUP 200 > > static inline u32 ahci_port_base(u32 base, u32 port) > { >