[U-Boot] [PATCH] whitespace cleanups

[U-Boot] [PATCH] whitespace cleanups

[Pavel Machek]

Whitespace cleanups.

Signed-off-by: Pavel Machek <pavel@denx.de>

diff --git a/disk/part.c b/disk/part.c
index baceb19..ecc5e7e 100644
--- a/disk/part.c
+++ b/disk/part.c
@@ -333,7 +333,7 @@ static void print_part_header (const char *type, block_dev_desc_t * dev_desc)
 
 #endif /* any CONFIG_..._PARTITION */
 
-void print_part (block_dev_desc_t * dev_desc)
+void print_part(block_dev_desc_t * dev_desc)
 {
 
 		switch (dev_desc->part_type) {
@@ -381,8 +381,8 @@ void print_part (block_dev_desc_t * dev_desc)
 
 #endif /* HAVE_BLOCK_DEVICE */
 
-int get_partition_info(block_dev_desc_t *dev_desc, int part
-					, disk_partition_t *info)
+int get_partition_info(block_dev_desc_t *dev_desc, int part,
+		       disk_partition_t *info)
 {
 #ifdef HAVE_BLOCK_DEVICE
 
@@ -511,7 +511,7 @@ int get_device_and_partition(const char *ifname, const char *dev_part_str,
 	disk_partition_t tmpinfo;
 
 	/*
-	 * Special-case a psuedo block device "hostfs", to allow access to the
+	 * Special-case a pseudo block device "hostfs", to allow access to the
 	 * host's own filesystem.
 	 */
 	if (0 == strcmp(ifname, "hostfs")) {
diff --git a/include/altera.h b/include/altera.h
index 0327a1b..ae5f7ee 100644
--- a/include/altera.h
+++ b/include/altera.h
@@ -26,7 +26,7 @@ typedef enum {			/* typedef Altera_Family */
 	min_altera_type,	/* insert all new types after this */
 	Altera_ACEX1K,		/* ACEX1K Family */
 	Altera_CYC2,		/* CYCLONII Family */
-	Altera_StratixII,	/* StratixII Familiy */
+	Altera_StratixII,	/* StratixII Family */
 /* Add new models here */
 	max_altera_type		/* insert all new types before this */
 } Altera_Family;		/* end, typedef Altera_Family */

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[U-Boot] [PATCH] whitespace cleanups

[Jeroen Hofstee]

Hello Pavel,

On 19-07-14 23:50, Pavel Machek wrote:
> Whitespace cleanups.
>
> Signed-off-by: Pavel Machek <pavel@denx.de>
>
> diff --git a/disk/part.c b/disk/part.c
> index baceb19..ecc5e7e 100644
> --- a/disk/part.c
> +++ b/disk/part.c
> @@ -333,7 +333,7 @@ static void print_part_header (const char *type, block_dev_desc_t * dev_desc)
>   
>   #endif /* any CONFIG_..._PARTITION */
>   
> -void print_part (block_dev_desc_t * dev_desc)
> +void print_part(block_dev_desc_t * dev_desc)
>   {
>   
>   		switch (dev_desc->part_type) {
> @@ -381,8 +381,8 @@ void print_part (block_dev_desc_t * dev_desc)
>   

checkpatch says: ;)

ERROR: "foo * bar" should be "foo *bar"
#26: FILE: disk/part.c:336:
+void print_part(block_dev_desc_t * dev_desc)

Regards,
Jeroen

[U-Boot] [PATCH] whitespace cleanups

[Pavel Machek]

On Sun 2014-07-20 00:02:37, Jeroen Hofstee wrote:
> Hello Pavel,
> 
> On 19-07-14 23:50, Pavel Machek wrote:
> >Whitespace cleanups.
> >
> >Signed-off-by: Pavel Machek <pavel@denx.de>
> >
> >diff --git a/disk/part.c b/disk/part.c
> >index baceb19..ecc5e7e 100644
> >--- a/disk/part.c
> >+++ b/disk/part.c
> >@@ -333,7 +333,7 @@ static void print_part_header (const char *type, block_dev_desc_t * dev_desc)
> >  #endif /* any CONFIG_..._PARTITION */
> >-void print_part (block_dev_desc_t * dev_desc)
> >+void print_part(block_dev_desc_t * dev_desc)
> >  {
> >  		switch (dev_desc->part_type) {
> >@@ -381,8 +381,8 @@ void print_part (block_dev_desc_t * dev_desc)
> 
> checkpatch says: ;)
> 
> ERROR: "foo * bar" should be "foo *bar"
> #26: FILE: disk/part.c:336:
> +void print_part(block_dev_desc_t * dev_desc)

Yeah, I did not fix _all_ broken whitespace, just some. Note that I'm
not adding the error.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[U-Boot] [PATCH] whitespace cleanups

[Jeroen Hofstee]

Hello Pavel,

On 20-07-14 00:13, Pavel Machek wrote:
> On Sun 2014-07-20 00:02:37, Jeroen Hofstee wrote:
>> Hello Pavel,
>>
>> On 19-07-14 23:50, Pavel Machek wrote:
>>> Whitespace cleanups.
>>>
>>> Signed-off-by: Pavel Machek <pavel@denx.de>
>>>
>>> diff --git a/disk/part.c b/disk/part.c
>>> index baceb19..ecc5e7e 100644
>>> --- a/disk/part.c
>>> +++ b/disk/part.c
>>> @@ -333,7 +333,7 @@ static void print_part_header (const char *type, block_dev_desc_t * dev_desc)
>>>   #endif /* any CONFIG_..._PARTITION */
>>> -void print_part (block_dev_desc_t * dev_desc)
>>> +void print_part(block_dev_desc_t * dev_desc)
>>>   {
>>>   		switch (dev_desc->part_type) {
>>> @@ -381,8 +381,8 @@ void print_part (block_dev_desc_t * dev_desc)
>> checkpatch says: ;)
>>
>> ERROR: "foo * bar" should be "foo *bar"
>> #26: FILE: disk/part.c:336:
>> +void print_part(block_dev_desc_t * dev_desc)
> Yeah, I did not fix _all_ broken whitespace, just some. Note that I'm
> not adding the error.
> 								

This is only about a line you touch. And patch submissions should be
checked by checkpatch or at least mention why you don't comply.

Regards,
Jeroen

[U-Boot] whitespace cleanups

[Tom Rini]

On Sat, Jul 19, 2014 at 11:50:44PM +0200, Pavel Machek wrote:

> Whitespace cleanups.
> 
> Signed-off-by: Pavel Machek <pavel@denx.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140722/5154ad87/attachment.pgp>

[U-Boot] [PATCH] cleanup disk/part.c whitespace

[Pavel Machek]

Cleanup disk/part.c
    
Signed-off-by: Pavel Machek <pavel@denx.de>

diff --git a/disk/part.c b/disk/part.c
index ecc5e7e..cfd77b0 100644
--- a/disk/part.c
+++ b/disk/part.c
@@ -133,7 +133,7 @@ typedef lbaint_t lba512_t;
  * Overflowless variant of (block_count * mul_by / div_by)
  * when div_by > mul_by
  */
-static lba512_t lba512_muldiv (lba512_t block_count, lba512_t mul_by, lba512_t div_by)
+static lba512_t lba512_muldiv(lba512_t block_count, lba512_t mul_by, lba512_t div_by)
 {
 	lba512_t bc_quot, bc_rem;
 
@@ -215,7 +215,8 @@ void dev_print (block_dev_desc_t *dev_desc)
 
 		lba512 = (lba * (dev_desc->blksz/512));
 		/* round to 1 digit */
-		mb = lba512_muldiv(lba512, 10, 2048);	/* 2048 = (1024 * 1024) / 512 MB */
+		/* 2048 = (1024 * 1024) / 512 MB */
+		mb = lba512_muldiv(lba512, 10, 2048);
 
 		mb_quot	= mb / 10;
 		mb_rem	= mb - (10 * mb_quot);
@@ -248,7 +249,7 @@ void dev_print (block_dev_desc_t *dev_desc)
 
 #ifdef HAVE_BLOCK_DEVICE
 
-void init_part (block_dev_desc_t * dev_desc)
+void init_part(block_dev_desc_t *dev_desc)
 {
 #ifdef CONFIG_ISO_PARTITION
 	if (test_part_iso(dev_desc) == 0) {
@@ -295,7 +296,7 @@ void init_part (block_dev_desc_t * dev_desc)
 	defined(CONFIG_AMIGA_PARTITION) || \
 	defined(CONFIG_EFI_PARTITION)
 
-static void print_part_header (const char *type, block_dev_desc_t * dev_desc)
+static void print_part_header(const char *type, block_dev_desc_t *dev_desc)
 {
 	puts ("\nPartition Map for ");
 	switch (dev_desc->if_type) {

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[U-Boot] cleanup disk/part.c whitespace

[Tom Rini]

On Tue, Sep 09, 2014 at 03:19:42PM +0200, Pavel Machek wrote:

> Cleanup disk/part.c
>     
> Signed-off-by: Pavel Machek <pavel@denx.de>

Applied to u-boot/master, thanks!


-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140925/0e5db9fa/attachment.pgp>