From: Jeroen Hofstee <jeroen@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] whitespace cleanups
Date: Sun, 20 Jul 2014 00:23:04 +0200 [thread overview]
Message-ID: <53CAEFC8.90706@myspectrum.nl> (raw)
In-Reply-To: <20140719221356.GB7405@amd.pavel.ucw.cz>
Hello Pavel,
On 20-07-14 00:13, Pavel Machek wrote:
> On Sun 2014-07-20 00:02:37, Jeroen Hofstee wrote:
>> Hello Pavel,
>>
>> On 19-07-14 23:50, Pavel Machek wrote:
>>> Whitespace cleanups.
>>>
>>> Signed-off-by: Pavel Machek <pavel@denx.de>
>>>
>>> diff --git a/disk/part.c b/disk/part.c
>>> index baceb19..ecc5e7e 100644
>>> --- a/disk/part.c
>>> +++ b/disk/part.c
>>> @@ -333,7 +333,7 @@ static void print_part_header (const char *type, block_dev_desc_t * dev_desc)
>>> #endif /* any CONFIG_..._PARTITION */
>>> -void print_part (block_dev_desc_t * dev_desc)
>>> +void print_part(block_dev_desc_t * dev_desc)
>>> {
>>> switch (dev_desc->part_type) {
>>> @@ -381,8 +381,8 @@ void print_part (block_dev_desc_t * dev_desc)
>> checkpatch says: ;)
>>
>> ERROR: "foo * bar" should be "foo *bar"
>> #26: FILE: disk/part.c:336:
>> +void print_part(block_dev_desc_t * dev_desc)
> Yeah, I did not fix _all_ broken whitespace, just some. Note that I'm
> not adding the error.
>
This is only about a line you touch. And patch submissions should be
checked by checkpatch or at least mention why you don't comply.
Regards,
Jeroen
next prev parent reply other threads:[~2014-07-19 22:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-19 21:50 [U-Boot] [PATCH] whitespace cleanups Pavel Machek
2014-07-19 22:02 ` Jeroen Hofstee
2014-07-19 22:13 ` Pavel Machek
2014-07-19 22:23 ` Jeroen Hofstee [this message]
2014-09-09 13:19 ` [U-Boot] [PATCH] cleanup disk/part.c whitespace Pavel Machek
2014-09-25 14:44 ` [U-Boot] " Tom Rini
2014-07-22 19:24 ` [U-Boot] whitespace cleanups Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CAEFC8.90706@myspectrum.nl \
--to=jeroen@myspectrum.nl \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox