From: Jeroen Hofstee <jeroen@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] buildman: make sure to invoke GNU Make
Date: Sun, 20 Jul 2014 20:13:06 +0200 [thread overview]
Message-ID: <53CC06B2.2090806@myspectrum.nl> (raw)
In-Reply-To: <1405588682-10724-4-git-send-email-yamada.m@jp.panasonic.com>
Hello Masahiro,
On 17-07-14 11:18, Masahiro Yamada wrote:
> Since the command name 'make' is not GNU Make on some platforms
> such as FreeBSD, MAKEALL should call the make via scripts/gnu_make.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
>
> tools/buildman/builder.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py
> index 4a2d753..c68cc8c 100644
> --- a/tools/buildman/builder.py
> +++ b/tools/buildman/builder.py
> @@ -667,7 +667,8 @@ class Builder:
> args: Arguments to pass to make
> kwargs: Arguments to pass to command.RunPipe()
> """
> - cmd = ['make'] + list(args)
> + gnu_make = os.path.join(self.git_dir, '../scripts/gnu_make')
> + cmd = [gnu_make] + list(args)
> result = command.RunPipe([cmd], capture=True, capture_stderr=True,
> cwd=cwd, raise_on_error=False, **kwargs)
> return result
with a trick to let buildman call clang, this works
fine on FreeBSD.
Tested-By: Jeroen Hofstee <jeroen@myspectrum.nl>
Regards,
Jeroen
prev parent reply other threads:[~2014-07-20 18:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 9:17 [U-Boot] [PATCH 0/3] Do not hard-code the command name 'make' in upper-level tools Masahiro Yamada
2014-07-17 9:18 ` [U-Boot] [PATCH 1/3] scripts: add scripts/gnu_make to not hard-code make command Masahiro Yamada
2014-07-18 18:19 ` Jeroen Hofstee
2014-07-22 3:54 ` Masahiro Yamada
2014-07-17 9:18 ` [U-Boot] [PATCH 2/3] MAKEALL: make sure to invoke GNU Make Masahiro Yamada
2014-07-18 18:29 ` Jeroen Hofstee
2014-07-19 4:41 ` Simon Glass
2014-07-17 9:18 ` [U-Boot] [PATCH 3/3] buildman: " Masahiro Yamada
2014-07-19 4:40 ` Simon Glass
2014-07-20 18:13 ` Jeroen Hofstee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CC06B2.2090806@myspectrum.nl \
--to=jeroen@myspectrum.nl \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox