[U-Boot] [PATCH 1/2] sunxi: Use Thumb2 and move stack to gain more SRAM space in FEL mode

Ian Campbell
2014-07-21T18:31:45Z

On Fri, 2014-07-18 at 20:09 +0300, Siarhei Siamashka wrote:

>
> http://lists.phcomp.co.uk/pipermail/arm-netbook/2012-June/004341.html

I think a better reference is
https://github.com/hno/Allwinner-Info/blob/master/FEL-usb/USB-protocol.txt

> +.syntax unified
> +.text
> +.arm
> +.arch armv7a
> +.p2align 2
> +
> +.globl _start_fel

Is there any reason not to use ENTRY() for this?

> +.globl s_init
> +.globl __bss_start
> +.globl __bss_end

I don't think you need .globl to access external symbols, all .globl
does is control the visibility of things defined in this file. IOW you
can drop all 3 of these AFAICT.

[...]
> + /* Pass control to the 's_init()' function */
> + b s_init

Since this code is in arm mode and s_init will, I think, be in Thumb
mode after this patch shouldn't this be a bx?

Ian.