public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/b4860: Updated default hwconfig so as to enable only CPC2
Date: Tue, 22 Jul 2014 14:39:18 -0700	[thread overview]
Message-ID: <53CEDA06.7020305@freescale.com> (raw)
In-Reply-To: <1404281615-31186-1-git-send-email-shaveta@freescale.com>

On 07/01/2014 11:13 PM, Shaveta Leekha wrote:
> CPC1 is not being enabled by default as powerpc is supposed to
> use only CPC2.
> 
> Signed-off-by: Shaveta Leekha <shaveta@freescale.com>
> Signed-off-by: Sandeep Singh <Sandeep@freescale.com>
> ---
>  include/configs/B4860QDS.h |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/include/configs/B4860QDS.h b/include/configs/B4860QDS.h
> index 1af9ba6..53fdac7 100644
> --- a/include/configs/B4860QDS.h
> +++ b/include/configs/B4860QDS.h
> @@ -820,8 +820,14 @@ unsigned long get_board_ddr_clk(void);
>  
>  #define __USB_PHY_TYPE	ulpi
>  
> +#ifdef CONFIG_PPC_B4860
> +#define HWCONFIG	"hwconfig=fsl_ddr:ctlr_intlv=null,en_cpc:cpc2,"
> +#else
> +#define	HWCONFIG	"hwconfig=fsl_ddr:ctlr_intlv=null,"
> +#endif
> +
>  #define	CONFIG_EXTRA_ENV_SETTINGS				\
> -	"hwconfig=fsl_ddr:ctlr_intlv=null,"		\
> +	HWCONFIG						\
>  	"bank_intlv=cs0_cs1;"					\
>  	"usb1:dr_mode=host,phy_type=" __stringify(__USB_PHY_TYPE) "\0"\
>  	"netdev=eth0\0"						\
> 
Did you try this patch on a board? You inserted "en_cpc:cpc2" at a wrong place.
You actually broke into the setting for DDR. When you move out hwconfig string,
you only removed partially.

York

  reply	other threads:[~2014-07-22 21:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-02  6:13 [U-Boot] [PATCH] powerpc/b4860: Updated default hwconfig so as to enable only CPC2 Shaveta Leekha
2014-07-22 21:39 ` York Sun [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-09-03 10:32 Shaveta Leekha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CEDA06.7020305@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox