public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] enabling ecc on P2041 and QoreIQ familly not valid for memory >= 4GB
Date: Tue, 22 Jul 2014 15:53:33 -0700	[thread overview]
Message-ID: <53CEEB6D.30404@freescale.com> (raw)
In-Reply-To: <53C91D25.3030204@kontron.com>

On 07/18/2014 06:11 AM, Benoit Sansoni wrote:
> Hi ,
> 
> I found out an issue when enabling ECC for P2041 platform with an amount
> of memory of 8GB.
> The routine "void dma_meminit(uint val, uint size)" is not adapted to
> manage memory size greater or equal to 4GB due to the 'uint' type.
> With this typing the dma_meminit sees 0 as size when memory is for
> example at 8GB. So the ECC part of the memory is not initialized and
> when going in memory the code crash.
> To correct it you need to use phys_size_t type instead of uint.
> It is the same thing for all routines that are called by "dma_meminit".
> I attached a patch that able to correct it easily.
> This patch should be integrated in the main branch I think so.
> 
> Regards,
> Benoit
> 

This is a valid concern. Some code started when we had far less memory. We need
to comb through the code to fix more of them.

York

  reply	other threads:[~2014-07-22 22:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18 13:11 [U-Boot] enabling ecc on P2041 and QoreIQ familly not valid for memory >= 4GB Benoit Sansoni
2014-07-22 22:53 ` York Sun [this message]
2014-07-23  7:21   ` Benoit Sansoni
2014-07-23 16:32     ` York Sun
2014-07-24  6:56       ` Benoit Sansoni
2014-08-12 18:07         ` York Sun
2014-08-25 12:35           ` Benoit Sansoni
2014-09-22 17:13             ` York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CEEB6D.30404@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox