[U-Boot] [PATCH] ARM: zynq: Show ECC status on the same line as DRAM size

[U-Boot] [PATCH] ARM: zynq: Show ECC status on the same line as DRAM size

[Michal Simek]

Without this patch is DRAM size one line below DRAM:
which is not nice

Origin:
I2C:   ready
DRAM:  ECC disabled
1 GiB
Now running in RAM - U-Boot at: 3ff59000
MMC:   zynq_sdhci: 0

Fixed by this patch:
I2C:   ready
DRAM:  ECC disabled 1 GiB
Now running in RAM - U-Boot at: 3ff59000
MMC:   zynq_sdhci: 0
Using default environment

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

Based on http://patchwork.ozlabs.org/patch/347048/

---
 arch/arm/cpu/armv7/zynq/ddrc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/cpu/armv7/zynq/ddrc.c b/arch/arm/cpu/armv7/zynq/ddrc.c
index e0ed3bfb4350..1ea086d52079 100644
--- a/arch/arm/cpu/armv7/zynq/ddrc.c
+++ b/arch/arm/cpu/armv7/zynq/ddrc.c
@@ -34,7 +34,7 @@ void zynq_ddrc_init(void)
 	/* ECC is enabled when memory is in 16bit mode and it is enabled */
 	if ((ecctype == ZYNQ_DDRC_ECC_SCRUBREG_ECCMODE_SECDED) &&
 	    (width == ZYNQ_DDRC_CTRLREG_BUSWIDTH_16BIT)) {
-		puts("Memory: ECC enabled\n");
+		puts("ECC enabled ");
 		/*
 		 * Clear the first 1MB because it is not initialized from
 		 * first stage bootloader. To get ECC to work all memory has
@@ -42,6 +42,6 @@ void zynq_ddrc_init(void)
 		 */
 		memset((void *)0, 0, 1 * 1024 * 1024);
 	} else {
-		puts("Memory: ECC disabled\n");
+		puts("ECC disabled ");
 	}
 }
--
1.8.2.3

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140515/07bf8d49/attachment.pgp>

[U-Boot] [PATCH] ARM: zynq: Show ECC status on the same line as DRAM size

[Masahiro Yamada]

Hi Michal,

On Thu, 15 May 2014 09:46:02 +0200
Michal Simek <michal.simek@xilinx.com> wrote:

> Without this patch is DRAM size one line below DRAM:
> which is not nice
> 
> Origin:
> I2C:   ready
> DRAM:  ECC disabled
> 1 GiB
> Now running in RAM - U-Boot at: 3ff59000
> MMC:   zynq_sdhci: 0


Strange. "Memory: " is missing.


As far as I tested, Origin should look like:


DRAM:  Memory: ECC disabled
1 GiB



The other parts look good!


Tested-by: Masahiro Yamada <yamada.m@jp.panasonic.com>






Best Regards
Masahiro Yamada

[U-Boot] [PATCH] ARM: zynq: Show ECC status on the same line as DRAM size

[Michal Simek]

On 07/23/2014 05:35 AM, Masahiro Yamada wrote:
> Hi Michal,
> 
> On Thu, 15 May 2014 09:46:02 +0200
> Michal Simek <michal.simek@xilinx.com> wrote:
> 
>> Without this patch is DRAM size one line below DRAM:
>> which is not nice
>>
>> Origin:
>> I2C:   ready
>> DRAM:  ECC disabled
>> 1 GiB
>> Now running in RAM - U-Boot at: 3ff59000
>> MMC:   zynq_sdhci: 0
> 
> 
> Strange. "Memory: " is missing.
> 
> 
> As far as I tested, Origin should look like:
> 
> 
> DRAM:  Memory: ECC disabled
> 1 GiB

you are right. Not sure why it is not here.

> 
> The other parts look good!
> 
> 
> Tested-by: Masahiro Yamada <yamada.m@jp.panasonic.com>

I have fixed commit message and applied.

Thanks,
Michal



-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140723/a5f0c136/attachment.pgp>