From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] ODROID dynamic memory initialization
Date: Wed, 23 Jul 2014 17:04:29 +0200 [thread overview]
Message-ID: <53CFCEFD.5040603@samsung.com> (raw)
In-Reply-To: <CAD8Lp47km-yb3GajAaXPFSazCQmzGO1DWWcDyY5+90GETo=w7A@mail.gmail.com>
Hi Daniel,
On 07/23/2014 02:27 PM, Daniel Drake wrote:
> On Tue, Jul 22, 2014 at 2:08 PM, Daniel Drake <drake@endlessm.com> wrote:
>> While looking at the old uboot from hardkernel, I'm curious about
>> CONFIG_CLK_BUS_DMC_220_440, which is set by default. This appears to
>> run the memory at a high speed, by writing certain registers in the
>> Dynamic Memory Controller (e.g. TIMINGROW), and clocking MPLL to
>> 880MHz.
>>
>> Your uboot patches don't seem to touch DMC regs like TIMINGROW, and
>> also clock the MPLL at 800MHz.
I used my private config from trats2 device, but there is Exynos4412
rev. 1.1 - DMC freq is 400MHz.
I need to check the 880Mhz value for the MPLL and I will give you an info.
>
> I looked in more detail, and now understand better the SPL vs uboot division.
>
> The vendor code I was referring to above is SPL code.
>
> Since we are still using the same SPL as before, it means that MPLL
> and memory is already set up by the time the real/new uboot loads.
>
> So I think there should be no need to modify MPLL, and I wonder if
> most of the other clock configuration code in your patches is also
> unnecessary.
>
> Thoughts?
>
> Thanks
> Daniel
>
The BL2 is not a part of this patches, then maybe better is to configure
the clocks for proper values by u-boot, moreover when I
disable the clock configuration in u-boot then it can't boot - probably
because of bad uart config and maybe some more.
Thank you for testing this code, but I don't have too much time for play
with this config now.
I will test the MPLL with 880MHz tomorrow and it should be good enough,
but next if dev freq will be enabled in the kernel - then probably DMC
dividers will change without TIMINGROW change.
Thanks,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
next prev parent reply other threads:[~2014-07-23 15:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 13:08 [U-Boot] ODROID dynamic memory initialization Daniel Drake
2014-07-23 12:27 ` Daniel Drake
2014-07-23 15:04 ` Przemyslaw Marczak [this message]
2014-07-24 10:42 ` [U-Boot] [PATCH] odroid: set MPLL clock to 880MHz Przemyslaw Marczak
2014-07-24 10:58 ` Przemyslaw Marczak
2014-09-05 6:55 ` Minkyu Kang
2014-09-05 10:50 ` Przemyslaw Marczak
2014-09-11 5:03 ` Minkyu Kang
2014-09-11 5:09 ` Jaehoon Chung
2014-09-11 7:25 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CFCEFD.5040603@samsung.com \
--to=p.marczak@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox