From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeroen Hofstee Date: Wed, 23 Jul 2014 21:24:00 +0200 Subject: [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size In-Reply-To: <20140723180350.GE1847@bill-the-cat> References: <1406074112-18161-1-git-send-email-judge.packham@gmail.com> <20140723180350.GE1847@bill-the-cat> Message-ID: <53D00BD0.6010502@myspectrum.nl> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 23-07-14 20:03, Tom Rini wrote: > On Wed, Jul 23, 2014 at 04:27:36AM -0600, Simon Glass wrote: >> On 22 July 2014 18:08, Chris Packham wrote: >>> file_size was being calculated using back-ticks but map_size uses >>> $(shell ...). Update the file_size calculation to use $(shell ...). >>> >>> Signed-off-by: Chris Packham >> Acked-by: Simon Glass >> >> But you might want to look at this. >> >> http://patchwork.ozlabs.org/patch/371936/ > Yeah, Jeroen, can we get a v2 of your patch that uses $(shell ... )? > Thanks! > > no problem. For the record I have not seen any issues with mentioned gmake version. But using $(shell .. ) seem like a sane thing to do. v2 is on its way, running MAKEALL for arm (can we keep it?). Chris: blackfin targets seem to rely on the same construct btw... Regards, Jeroen