public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 1/2] ppc: Make ppc4xx ready for CONFIG_SYS_GENERIC_BOARD
Date: Thu, 24 Jul 2014 18:40:15 +0200	[thread overview]
Message-ID: <53D136EF.5010207@denx.de> (raw)
In-Reply-To: <1404126346-11312-2-git-send-email-dirk.eibach@gdsys.cc>

On 30.06.2014 13:05, dirk.eibach at gdsys.cc wrote:
> From: Dirk Eibach <dirk.eibach@gdsys.cc>
> 
> The generic board  infrastructure assumes that gd is set by
> arch code.
> 
> Signed-off-by: Dirk Eibach <dirk.eibach@gdsys.cc>
> ---
> 
>   arch/powerpc/cpu/ppc4xx/cpu_init.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/powerpc/cpu/ppc4xx/cpu_init.c b/arch/powerpc/cpu/ppc4xx/cpu_init.c
> index d465dcd..86891c1 100644
> --- a/arch/powerpc/cpu/ppc4xx/cpu_init.c
> +++ b/arch/powerpc/cpu/ppc4xx/cpu_init.c
> @@ -451,6 +451,8 @@ cpu_init_f (void)
>   	mtdcr(PLB4A1_ACR, (mfdcr(PLB4A1_ACR) & ~PLB4Ax_ACR_RDP_MASK) |
>   	      PLB4Ax_ACR_RDP_4DEEP);
>   #endif /* CONFIG_440SP/SPE || CONFIG_460EX/GT || CONFIG_405EX */
> +
> +	gd = (gd_t *)(CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_GBL_DATA_OFFSET);
>   }

After applying both patches I get this:

Configuring for intip - Board: intip, Options: INTIB
arch/powerpc/cpu/ppc4xx/cpu_init.c:455:2: error: 'gd' undeclared (first use in this function)
make[1]: *** [arch/powerpc/cpu/ppc4xx/cpu_init.o] Error 1
make: *** [arch/powerpc/cpu/ppc4xx] Error 2
powerpc-linux-size: './u-boot': No such file
arch/powerpc/cpu/ppc4xx/cpu_init.c: In function 'cpu_init_f':
arch/powerpc/cpu/ppc4xx/cpu_init.c:455:2: error: 'gd' undeclared (first use in this function)
arch/powerpc/cpu/ppc4xx/cpu_init.c:455:2: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [arch/powerpc/cpu/ppc4xx/cpu_init.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [arch/powerpc/cpu/ppc4xx] Error 2
make: *** Waiting for unfinished jobs....


Please fix and resubmit. And sorry for the delay.

Thanks,
Stefan

  reply	other threads:[~2014-07-24 16:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30 11:05 [U-Boot] [PATCH v1 0/2] Add CONFIG_SYS_GENERIC_BOARD to all gdsys boards dirk.eibach at gdsys.cc
2014-06-30 11:05 ` [U-Boot] [PATCH v1 1/2] ppc: Make ppc4xx ready for CONFIG_SYS_GENERIC_BOARD dirk.eibach at gdsys.cc
2014-07-24 16:40   ` Stefan Roese [this message]
2014-06-30 11:05 ` [U-Boot] [PATCH v1 2/2] board: Add CONFIG_SYS_GENERIC_BOARD to all gdsys boards dirk.eibach at gdsys.cc
2014-07-23  6:57 ` [U-Boot] [PATCH v1 0/2] " Dirk Eibach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D136EF.5010207@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox