public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v1 0/2] Add CONFIG_SYS_GENERIC_BOARD to all gdsys boards
@ 2014-06-30 11:05 dirk.eibach at gdsys.cc
  2014-06-30 11:05 ` [U-Boot] [PATCH v1 1/2] ppc: Make ppc4xx ready for CONFIG_SYS_GENERIC_BOARD dirk.eibach at gdsys.cc
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: dirk.eibach at gdsys.cc @ 2014-06-30 11:05 UTC (permalink / raw)
  To: u-boot

From: Dirk Eibach <dirk.eibach@gdsys.cc>




Dirk Eibach (2):
  ppc: Make ppc4xx ready for CONFIG_SYS_GENERIC_BOARD
  board: Add CONFIG_SYS_GENERIC_BOARD to all gdsys boards

 arch/powerpc/cpu/ppc4xx/cpu_init.c | 2 ++
 include/configs/controlcenterd.h   | 2 ++
 include/configs/dlvision-10g.h     | 1 +
 include/configs/dlvision.h         | 1 +
 include/configs/gdppc440etx.h      | 1 +
 include/configs/intip.h            | 1 +
 include/configs/io.h               | 1 +
 include/configs/io64.h             | 1 +
 include/configs/iocon.h            | 1 +
 include/configs/neo.h              | 1 +
 10 files changed, 12 insertions(+)

-- 
1.8.3

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH v1 1/2] ppc: Make ppc4xx ready for CONFIG_SYS_GENERIC_BOARD
  2014-06-30 11:05 [U-Boot] [PATCH v1 0/2] Add CONFIG_SYS_GENERIC_BOARD to all gdsys boards dirk.eibach at gdsys.cc
@ 2014-06-30 11:05 ` dirk.eibach at gdsys.cc
  2014-07-24 16:40   ` Stefan Roese
  2014-06-30 11:05 ` [U-Boot] [PATCH v1 2/2] board: Add CONFIG_SYS_GENERIC_BOARD to all gdsys boards dirk.eibach at gdsys.cc
  2014-07-23  6:57 ` [U-Boot] [PATCH v1 0/2] " Dirk Eibach
  2 siblings, 1 reply; 5+ messages in thread
From: dirk.eibach at gdsys.cc @ 2014-06-30 11:05 UTC (permalink / raw)
  To: u-boot

From: Dirk Eibach <dirk.eibach@gdsys.cc>

The generic board  infrastructure assumes that gd is set by
arch code.

Signed-off-by: Dirk Eibach <dirk.eibach@gdsys.cc>
---

 arch/powerpc/cpu/ppc4xx/cpu_init.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/powerpc/cpu/ppc4xx/cpu_init.c b/arch/powerpc/cpu/ppc4xx/cpu_init.c
index d465dcd..86891c1 100644
--- a/arch/powerpc/cpu/ppc4xx/cpu_init.c
+++ b/arch/powerpc/cpu/ppc4xx/cpu_init.c
@@ -451,6 +451,8 @@ cpu_init_f (void)
 	mtdcr(PLB4A1_ACR, (mfdcr(PLB4A1_ACR) & ~PLB4Ax_ACR_RDP_MASK) |
 	      PLB4Ax_ACR_RDP_4DEEP);
 #endif /* CONFIG_440SP/SPE || CONFIG_460EX/GT || CONFIG_405EX */
+
+	gd = (gd_t *)(CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_GBL_DATA_OFFSET);
 }
 
 /*
-- 
1.8.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH v1 2/2] board: Add CONFIG_SYS_GENERIC_BOARD to all gdsys boards
  2014-06-30 11:05 [U-Boot] [PATCH v1 0/2] Add CONFIG_SYS_GENERIC_BOARD to all gdsys boards dirk.eibach at gdsys.cc
  2014-06-30 11:05 ` [U-Boot] [PATCH v1 1/2] ppc: Make ppc4xx ready for CONFIG_SYS_GENERIC_BOARD dirk.eibach at gdsys.cc
@ 2014-06-30 11:05 ` dirk.eibach at gdsys.cc
  2014-07-23  6:57 ` [U-Boot] [PATCH v1 0/2] " Dirk Eibach
  2 siblings, 0 replies; 5+ messages in thread
From: dirk.eibach at gdsys.cc @ 2014-06-30 11:05 UTC (permalink / raw)
  To: u-boot

From: Dirk Eibach <dirk.eibach@gdsys.cc>

Add the generic board infrastructure to all gdsys boards.

Signed-off-by: Dirk Eibach <dirk.eibach@gdsys.cc>
---

 include/configs/controlcenterd.h | 2 ++
 include/configs/dlvision-10g.h   | 1 +
 include/configs/dlvision.h       | 1 +
 include/configs/gdppc440etx.h    | 1 +
 include/configs/intip.h          | 1 +
 include/configs/io.h             | 1 +
 include/configs/io64.h           | 1 +
 include/configs/iocon.h          | 1 +
 include/configs/neo.h            | 1 +
 9 files changed, 10 insertions(+)

diff --git a/include/configs/controlcenterd.h b/include/configs/controlcenterd.h
index 868813f..ed07a0f 100644
--- a/include/configs/controlcenterd.h
+++ b/include/configs/controlcenterd.h
@@ -45,6 +45,8 @@
 #define CONFIG_CONTROLCENTERD
 #define CONFIG_MP			/* support multiple processors */
 
+#define CONFIG_SYS_GENERIC_BOARD
+
 #define CONFIG_SYS_NO_FLASH
 #define CONFIG_ENABLE_36BIT_PHYS
 #define CONFIG_FSL_LAW			/* Use common FSL init code */
diff --git a/include/configs/dlvision-10g.h b/include/configs/dlvision-10g.h
index 7877897..ec85db2 100644
--- a/include/configs/dlvision-10g.h
+++ b/include/configs/dlvision-10g.h
@@ -24,6 +24,7 @@
 #define CONFIG_BOARD_EARLY_INIT_R
 #define CONFIG_MISC_INIT_R
 #define CONFIG_LAST_STAGE_INIT
+#define CONFIG_SYS_GENERIC_BOARD
 
 #define CONFIG_SYS_CLK_FREQ	33333333 /* external frequency to pll   */
 
diff --git a/include/configs/dlvision.h b/include/configs/dlvision.h
index 1e86c55..af0d602 100644
--- a/include/configs/dlvision.h
+++ b/include/configs/dlvision.h
@@ -22,6 +22,7 @@
 
 #define CONFIG_BOARD_EARLY_INIT_F	/* call board_early_init_f */
 #define CONFIG_MISC_INIT_R		/* call misc_init_r */
+#define CONFIG_SYS_GENERIC_BOARD
 
 #define CONFIG_SYS_CLK_FREQ	33333333 /* external frequency to pll   */
 
diff --git a/include/configs/gdppc440etx.h b/include/configs/gdppc440etx.h
index 6810b3b..12fd75d 100644
--- a/include/configs/gdppc440etx.h
+++ b/include/configs/gdppc440etx.h
@@ -32,6 +32,7 @@
 
 #define CONFIG_BOARD_EARLY_INIT_F	1	/* call board_early_init_f*/
 #define CONFIG_MISC_INIT_R		1	/* call misc_init_r()     */
+#define CONFIG_SYS_GENERIC_BOARD
 
 #undef CONFIG_ZERO_BOOTDELAY_CHECK     /* ignore keypress on bootdelay==0 */
 #define CONFIG_AUTOBOOT_KEYED          /* use key strings to stop autoboot */
diff --git a/include/configs/intip.h b/include/configs/intip.h
index b56b3aa..928eb5b 100644
--- a/include/configs/intip.h
+++ b/include/configs/intip.h
@@ -45,6 +45,7 @@
 #define CONFIG_BOARD_EARLY_INIT_F	1	/* Call board_early_init_f */
 #define CONFIG_BOARD_EARLY_INIT_R	1	/* Call board_early_init_r */
 #define CONFIG_MISC_INIT_R		1	/* Call misc_init_r */
+#define CONFIG_SYS_GENERIC_BOARD
 #define CONFIG_BOARD_TYPES		1	/* support board types */
 #define CONFIG_FIT
 #define CFG_ALT_MEMTEST
diff --git a/include/configs/io.h b/include/configs/io.h
index 9da6cc6..8c8afef 100644
--- a/include/configs/io.h
+++ b/include/configs/io.h
@@ -24,6 +24,7 @@
 #define CONFIG_BOARD_EARLY_INIT_R
 #define CONFIG_MISC_INIT_R
 #define CONFIG_LAST_STAGE_INIT
+#define CONFIG_SYS_GENERIC_BOARD
 
 #define CONFIG_SYS_CLK_FREQ	33333333 /* external frequency to pll   */
 
diff --git a/include/configs/io64.h b/include/configs/io64.h
index 6915b20..2a9ff37 100644
--- a/include/configs/io64.h
+++ b/include/configs/io64.h
@@ -43,6 +43,7 @@
 #define CONFIG_BOARD_EARLY_INIT_R
 #define CONFIG_MISC_INIT_R
 #define CONFIG_LAST_STAGE_INIT
+#define CONFIG_SYS_GENERIC_BOARD
 
 #undef CONFIG_ZERO_BOOTDELAY_CHECK	/* ignore keypress on bootdelay==0 */
 #define CONFIG_AUTOBOOT_KEYED		/* use key strings to stop autoboot */
diff --git a/include/configs/iocon.h b/include/configs/iocon.h
index 79c4736..7fd7527 100644
--- a/include/configs/iocon.h
+++ b/include/configs/iocon.h
@@ -23,6 +23,7 @@
 #define CONFIG_BOARD_EARLY_INIT_F
 #define CONFIG_BOARD_EARLY_INIT_R
 #define CONFIG_LAST_STAGE_INIT
+#define CONFIG_SYS_GENERIC_BOARD
 
 #define CONFIG_SYS_CLK_FREQ	33333333 /* external frequency to pll   */
 
diff --git a/include/configs/neo.h b/include/configs/neo.h
index d549985..5fdeff1 100644
--- a/include/configs/neo.h
+++ b/include/configs/neo.h
@@ -25,6 +25,7 @@
 #define CONFIG_BOARD_EARLY_INIT_R
 #define CONFIG_MISC_INIT_R
 #define CONFIG_LAST_STAGE_INIT
+#define CONFIG_SYS_GENERIC_BOARD
 
 #define CONFIG_SYS_CLK_FREQ	33333333 /* external frequency to pll   */
 
-- 
1.8.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH v1 0/2] Add CONFIG_SYS_GENERIC_BOARD to all gdsys boards
  2014-06-30 11:05 [U-Boot] [PATCH v1 0/2] Add CONFIG_SYS_GENERIC_BOARD to all gdsys boards dirk.eibach at gdsys.cc
  2014-06-30 11:05 ` [U-Boot] [PATCH v1 1/2] ppc: Make ppc4xx ready for CONFIG_SYS_GENERIC_BOARD dirk.eibach at gdsys.cc
  2014-06-30 11:05 ` [U-Boot] [PATCH v1 2/2] board: Add CONFIG_SYS_GENERIC_BOARD to all gdsys boards dirk.eibach at gdsys.cc
@ 2014-07-23  6:57 ` Dirk Eibach
  2 siblings, 0 replies; 5+ messages in thread
From: Dirk Eibach @ 2014-07-23  6:57 UTC (permalink / raw)
  To: u-boot

Ping.

2014-06-30 13:05 GMT+02:00  <dirk.eibach@gdsys.cc>:
> From: Dirk Eibach <dirk.eibach@gdsys.cc>
>
>
>
>
> Dirk Eibach (2):
>   ppc: Make ppc4xx ready for CONFIG_SYS_GENERIC_BOARD
>   board: Add CONFIG_SYS_GENERIC_BOARD to all gdsys boards
>
>  arch/powerpc/cpu/ppc4xx/cpu_init.c | 2 ++
>  include/configs/controlcenterd.h   | 2 ++
>  include/configs/dlvision-10g.h     | 1 +
>  include/configs/dlvision.h         | 1 +
>  include/configs/gdppc440etx.h      | 1 +
>  include/configs/intip.h            | 1 +
>  include/configs/io.h               | 1 +
>  include/configs/io64.h             | 1 +
>  include/configs/iocon.h            | 1 +
>  include/configs/neo.h              | 1 +
>  10 files changed, 12 insertions(+)
>
> --
> 1.8.3
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH v1 1/2] ppc: Make ppc4xx ready for CONFIG_SYS_GENERIC_BOARD
  2014-06-30 11:05 ` [U-Boot] [PATCH v1 1/2] ppc: Make ppc4xx ready for CONFIG_SYS_GENERIC_BOARD dirk.eibach at gdsys.cc
@ 2014-07-24 16:40   ` Stefan Roese
  0 siblings, 0 replies; 5+ messages in thread
From: Stefan Roese @ 2014-07-24 16:40 UTC (permalink / raw)
  To: u-boot

On 30.06.2014 13:05, dirk.eibach at gdsys.cc wrote:
> From: Dirk Eibach <dirk.eibach@gdsys.cc>
> 
> The generic board  infrastructure assumes that gd is set by
> arch code.
> 
> Signed-off-by: Dirk Eibach <dirk.eibach@gdsys.cc>
> ---
> 
>   arch/powerpc/cpu/ppc4xx/cpu_init.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/powerpc/cpu/ppc4xx/cpu_init.c b/arch/powerpc/cpu/ppc4xx/cpu_init.c
> index d465dcd..86891c1 100644
> --- a/arch/powerpc/cpu/ppc4xx/cpu_init.c
> +++ b/arch/powerpc/cpu/ppc4xx/cpu_init.c
> @@ -451,6 +451,8 @@ cpu_init_f (void)
>   	mtdcr(PLB4A1_ACR, (mfdcr(PLB4A1_ACR) & ~PLB4Ax_ACR_RDP_MASK) |
>   	      PLB4Ax_ACR_RDP_4DEEP);
>   #endif /* CONFIG_440SP/SPE || CONFIG_460EX/GT || CONFIG_405EX */
> +
> +	gd = (gd_t *)(CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_GBL_DATA_OFFSET);
>   }

After applying both patches I get this:

Configuring for intip - Board: intip, Options: INTIB
arch/powerpc/cpu/ppc4xx/cpu_init.c:455:2: error: 'gd' undeclared (first use in this function)
make[1]: *** [arch/powerpc/cpu/ppc4xx/cpu_init.o] Error 1
make: *** [arch/powerpc/cpu/ppc4xx] Error 2
powerpc-linux-size: './u-boot': No such file
arch/powerpc/cpu/ppc4xx/cpu_init.c: In function 'cpu_init_f':
arch/powerpc/cpu/ppc4xx/cpu_init.c:455:2: error: 'gd' undeclared (first use in this function)
arch/powerpc/cpu/ppc4xx/cpu_init.c:455:2: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [arch/powerpc/cpu/ppc4xx/cpu_init.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [arch/powerpc/cpu/ppc4xx] Error 2
make: *** Waiting for unfinished jobs....


Please fix and resubmit. And sorry for the delay.

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-07-24 16:40 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-30 11:05 [U-Boot] [PATCH v1 0/2] Add CONFIG_SYS_GENERIC_BOARD to all gdsys boards dirk.eibach at gdsys.cc
2014-06-30 11:05 ` [U-Boot] [PATCH v1 1/2] ppc: Make ppc4xx ready for CONFIG_SYS_GENERIC_BOARD dirk.eibach at gdsys.cc
2014-07-24 16:40   ` Stefan Roese
2014-06-30 11:05 ` [U-Boot] [PATCH v1 2/2] board: Add CONFIG_SYS_GENERIC_BOARD to all gdsys boards dirk.eibach at gdsys.cc
2014-07-23  6:57 ` [U-Boot] [PATCH v1 0/2] " Dirk Eibach

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox