From mboxrd@z Thu Jan 1 00:00:00 1970 From: drEagle Date: Fri, 25 Jul 2014 18:36:35 +0200 Subject: [U-Boot] [PATCH v5 1/1] ARM: kirkwood: add mvsdio driver In-Reply-To: <53D26ECE.2050104@denx.de> References: <1406294864-6839-1-git-send-email-drEagle@doukki.net> <53D26ECE.2050104@denx.de> Message-ID: <53D28793.2020003@DOUKKI.NET> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefan, On 25/07/2014 16:50, Stefan Roese wrote: > On 25.07.2014 15:27, Gerald Kerma wrote: >> This patch add Marvell kirkwood MVSDIO/MMC driver >> and enable it for Sheevaplugs and OpenRD boards. >> >> Signed-off-by: Gerald Kerma > > Please don't send this patch as base64 encoded. It makes it impossible to apply this patch or run checkpatch on it. I use git send-email and I have used the default encoding [UTF-8], what is the preferred format that I may specify ? > Did you run it though checkpatch btw? yes, the results given is : total: 0 errors, 0 warnings, 0 checks, 744 lines checked Same for the coming v6 on 730 lines checked. > I suggest to rename the driver to mvebu_mmc.c instead. This MVEBU is the generally agreed upon abbreviation for Marvell SoC's (Orion, Kirkwood, Armada XP, 370 ...). Done, > Doesn't it make sense to move this code to init / enable the MMC driver into the arch/cpu/... SoC code? Instead of adding it to all the board specific files? Good idea > Here we have this code again. I suggest to move it to the kirkwood cpu.c file instead. Done I'll check and send a new version (v6). Do I rename the patch header ? Enjoy -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 538 bytes Desc: OpenPGP digital signature URL: