From: Jeroen Hofstee <jeroen@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 1/1] ARM: kirkwood: add mvsdio driver
Date: Fri, 25 Jul 2014 20:45:34 +0200 [thread overview]
Message-ID: <53D2A5CE.2020700@myspectrum.nl> (raw)
In-Reply-To: <53D29FBA.4080403@denx.de>
Hi,
On 25-07-14 20:19, Stefan Roese wrote:
> On 25.07.2014 19:07, Gerald Kerma wrote:
>> This patch add Marvell kirkwood MVSDIO/MMC driver
>> and enable it for Sheevaplugs and OpenRD boards.
>>
>> Signed-off-by: Gerald Kerma <drEagle@doukki.net>
>> ---
>>
>> Changes in v6:
>> - rename driver to mvebu_mmc
>> - renames constants and functions
>> - move mmc_init to kirkwood/cpu
>> - code cleaning
> <snip>
>> +
>> +#define mvebu_mmc_write(offs, val) writel(val, CONFIG_SYS_MMC_BASE +
>> (offs))
>> +#define mvebu_mmc_read(offs) readl(CONFIG_SYS_MMC_BASE + (offs))
>
> Wouldn't it be better to use functions instead of macros here?
>
or use structs?
Regards,
Jeroen
next prev parent reply other threads:[~2014-07-25 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 17:07 [U-Boot] [PATCH v6 1/1] ARM: kirkwood: add mvsdio driver Gerald Kerma
2014-07-25 18:19 ` Stefan Roese
2014-07-25 18:45 ` Jeroen Hofstee [this message]
2014-07-25 19:07 ` drEagle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D2A5CE.2020700@myspectrum.nl \
--to=jeroen@myspectrum.nl \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox