From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeroen Hofstee <jeroen@myspectrum.nl>
Date: Fri, 25 Jul 2014 20:45:34 +0200
Subject: [U-Boot] [PATCH v6 1/1] ARM: kirkwood: add mvsdio driver
In-Reply-To: <53D29FBA.4080403@denx.de>
References: <1406308054-26895-1-git-send-email-drEagle@doukki.net>
	<53D29FBA.4080403@denx.de>
Message-ID: <53D2A5CE.2020700@myspectrum.nl>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

On 25-07-14 20:19, Stefan Roese wrote:
> On 25.07.2014 19:07, Gerald Kerma wrote:
>> This patch add Marvell kirkwood MVSDIO/MMC driver
>> and enable it for Sheevaplugs and OpenRD boards.
>>
>> Signed-off-by: Gerald Kerma <drEagle@doukki.net>
>> ---
>>
>>   Changes in v6:
>>   - rename driver to mvebu_mmc
>>   - renames constants and functions
>>   - move mmc_init to kirkwood/cpu
>>   - code cleaning
> <snip>
>> +
>> +#define mvebu_mmc_write(offs, val) writel(val, CONFIG_SYS_MMC_BASE + 
>> (offs))
>> +#define mvebu_mmc_read(offs) readl(CONFIG_SYS_MMC_BASE + (offs))
>
> Wouldn't it be better to use functions instead of macros here?
>
or use structs?

Regards,
Jeroen