From: drEagle <drEagle@DOUKKI.NET>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 1/1] ARM: kirkwood: add mvsdio driver
Date: Fri, 25 Jul 2014 21:07:46 +0200 [thread overview]
Message-ID: <53D2AB02.3020301@DOUKKI.NET> (raw)
In-Reply-To: <53D29FBA.4080403@denx.de>
On 25/07/2014 20:19, Stefan Roese wrote:
> On 25.07.2014 19:07, Gerald Kerma wrote:
>> This patch add Marvell kirkwood MVSDIO/MMC driver
>> and enable it for Sheevaplugs and OpenRD boards.
>>
>> Signed-off-by: Gerald Kerma <drEagle@doukki.net>
>
> Thanks. This really looks better.
>
> Only some mostly nitpicking comments below.
correction added in next version.
>> diff --git a/include/configs/sheevaplug.h b/include/configs/sheevaplug.h
>> index ecc93bc..de38ad3 100644
>> --- a/include/configs/sheevaplug.h
>> +++ b/include/configs/sheevaplug.h
>> @@ -31,9 +31,11 @@
>> #define CONFIG_CMD_DHCP
>> #define CONFIG_CMD_ENV
>> #define CONFIG_CMD_MII
>> +#define CONFIG_CMD_MMC
>> #define CONFIG_CMD_NAND
>> #define CONFIG_CMD_PING
>> #define CONFIG_CMD_USB
>> +
>> /*
>> * mv-common.h should be defined after CMD configs since it used them
>> * to enable certain macros
>> @@ -49,13 +51,14 @@
>> #else
>> #define CONFIG_ENV_IS_NOWHERE 1 /* if env in SDRAM */
>> #endif
>> +
>> /*
>> * max 4k env size is enough, but in case of nand
>> * it has to be rounded to sector size
>> */
>> #define CONFIG_ENV_SIZE 0x20000 /* 128k */
>> -#define CONFIG_ENV_ADDR 0x60000
>> -#define CONFIG_ENV_OFFSET 0x60000 /* env starts here */
>> +#define CONFIG_ENV_ADDR 0x80000
>> +#define CONFIG_ENV_OFFSET 0x80000 /* env starts here */
>
> This change seems to be unrelated. And breaks compatibility with the environment. Or am I missing something?
Removed, but, the new u-boot.kwb image is greater than 0x60000. If you write environments or reset environments that will corrupt uboot and broke it.
May be fixed in another patch.
> Thanks for your patience!
>
> Stefan
V7 sent.
Enjoy,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 538 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140725/92aede03/attachment.pgp>
prev parent reply other threads:[~2014-07-25 19:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 17:07 [U-Boot] [PATCH v6 1/1] ARM: kirkwood: add mvsdio driver Gerald Kerma
2014-07-25 18:19 ` Stefan Roese
2014-07-25 18:45 ` Jeroen Hofstee
2014-07-25 19:07 ` drEagle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D2AB02.3020301@DOUKKI.NET \
--to=dreagle@doukki.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox