From mboxrd@z Thu Jan 1 00:00:00 1970 From: drEagle Date: Fri, 25 Jul 2014 21:07:46 +0200 Subject: [U-Boot] [PATCH v6 1/1] ARM: kirkwood: add mvsdio driver In-Reply-To: <53D29FBA.4080403@denx.de> References: <1406308054-26895-1-git-send-email-drEagle@doukki.net> <53D29FBA.4080403@denx.de> Message-ID: <53D2AB02.3020301@DOUKKI.NET> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 25/07/2014 20:19, Stefan Roese wrote: > On 25.07.2014 19:07, Gerald Kerma wrote: >> This patch add Marvell kirkwood MVSDIO/MMC driver >> and enable it for Sheevaplugs and OpenRD boards. >> >> Signed-off-by: Gerald Kerma > > Thanks. This really looks better. > > Only some mostly nitpicking comments below. correction added in next version. >> diff --git a/include/configs/sheevaplug.h b/include/configs/sheevaplug.h >> index ecc93bc..de38ad3 100644 >> --- a/include/configs/sheevaplug.h >> +++ b/include/configs/sheevaplug.h >> @@ -31,9 +31,11 @@ >> #define CONFIG_CMD_DHCP >> #define CONFIG_CMD_ENV >> #define CONFIG_CMD_MII >> +#define CONFIG_CMD_MMC >> #define CONFIG_CMD_NAND >> #define CONFIG_CMD_PING >> #define CONFIG_CMD_USB >> + >> /* >> * mv-common.h should be defined after CMD configs since it used them >> * to enable certain macros >> @@ -49,13 +51,14 @@ >> #else >> #define CONFIG_ENV_IS_NOWHERE 1 /* if env in SDRAM */ >> #endif >> + >> /* >> * max 4k env size is enough, but in case of nand >> * it has to be rounded to sector size >> */ >> #define CONFIG_ENV_SIZE 0x20000 /* 128k */ >> -#define CONFIG_ENV_ADDR 0x60000 >> -#define CONFIG_ENV_OFFSET 0x60000 /* env starts here */ >> +#define CONFIG_ENV_ADDR 0x80000 >> +#define CONFIG_ENV_OFFSET 0x80000 /* env starts here */ > > This change seems to be unrelated. And breaks compatibility with the environment. Or am I missing something? Removed, but, the new u-boot.kwb image is greater than 0x60000. If you write environments or reset environments that will corrupt uboot and broke it. May be fixed in another patch. > Thanks for your patience! > > Stefan V7 sent. Enjoy, -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 538 bytes Desc: OpenPGP digital signature URL: