From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 22/25] tools/kwboot: Sync with latest barebox version to support Armada XP
Date: Mon, 28 Jul 2014 08:47:13 +0200 [thread overview]
Message-ID: <53D5F1F1.9070403@denx.de> (raw)
In-Reply-To: <20140703220246.GA8506@w500.lan>
Hi Luka!
Sorry for the late reply to this comment.
On 04.07.2014 00:02, Luka Perkov wrote:
> Hi Stefan,
>
> On Fri, Jun 27, 2014 at 11:55:08AM +0200, Stefan Roese wrote:
>> The barebox version of the kwboot tool has evolved a bit. To support
>> Armada XP and Dove. Additionally a few minor fixes have been applied.
>> So lets sync with the latest barebox version.
>>
>> Please note that the main difference between both versions now is, that
>> the U-Boot version still supports the -p option, to dynamically patch
>> an image for UART boot mode. I didn't test it now though.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> ---
>>
>> tools/kwboot.c | 97 +++++++++++++++++++++++++++++++++++++++++++++++++---------
>> 1 file changed, 83 insertions(+), 14 deletions(-)
>
> ...
>
>> -#define KWBOOT_MSG_REQ_DELAY 10 /* ms */
>> -#define KWBOOT_MSG_RSP_TIMEO 50 /* ms */
>> +static unsigned char kwboot_msg_debug[] = {
>> + 0xDD, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77
>> +};
>> +
>> +#define KWBOOT_MSG_REQ_DELAY 1000 /* ms */
>> +#define KWBOOT_MSG_RSP_TIMEO 1000 /* ms */
>
> This causes problems on kirkwood. The old values should be kept, apply
> the patch below to this one. After that chage feel free to add Tested-by
> line.
>
> Tested-by: Luka Perkov <luka@openwrt.org>
>
> Now only to figure out why 21/25 breaks things on kirkwood.
>
> Luka
>
> diff --git a/tools/kwboot.c b/tools/kwboot.c
> index c47970e..ccc9d90 100644
> --- a/tools/kwboot.c
> +++ b/tools/kwboot.c
> @@ -42,8 +42,8 @@ static unsigned char kwboot_msg_debug[] = {
> 0xDD, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77
> };
>
> -#define KWBOOT_MSG_REQ_DELAY 1000 /* ms */
> -#define KWBOOT_MSG_RSP_TIMEO 1000 /* ms */
> +#define KWBOOT_MSG_REQ_DELAY 10 /* ms */
> +#define KWBOOT_MSG_RSP_TIMEO 50 /* ms */
Unfortunately these settings do not work with Armada XP. I tested a bit
and it seems that e.g. this setting works on Armada XP:
#define KWBOOT_MSG_REQ_DELAY 10 /* ms */
#define KWBOOT_MSG_RSP_TIMEO 1000 /* ms */
Could you please check this on your Kirkwood platform? And perhaps find
a configuration that works for the SoC's? That would be great!
Thanks,
Stefan
next prev parent reply other threads:[~2014-07-28 6:47 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 9:54 [U-Boot] [PATCH v1 0/25] Add Marvell Armada XP MV78460 SoC support Stefan Roese
2014-06-27 9:54 ` [U-Boot] [PATCH v1 01/25] sf: Add M25PX64 SPI NOR flash ID Stefan Roese
2014-07-03 20:14 ` Jagan Teki
2014-07-13 16:20 ` Jagan Teki
2014-06-27 9:54 ` [U-Boot] [PATCH v1 02/25] arm: kirkwood: spi.h: Add some missing parenthesis Stefan Roese
2014-07-03 20:15 ` Jagan Teki
2014-06-27 9:54 ` [U-Boot] [PATCH v1 03/25] spi: kirkwood_spi.c: Some fixes and cleanup Stefan Roese
2014-07-03 20:16 ` Jagan Teki
2014-06-27 9:54 ` [U-Boot] [PATCH v1 04/25] spi: kirkwood_spi.c: Make global variable static Stefan Roese
2014-07-03 20:18 ` Jagan Teki
2014-06-27 9:54 ` [U-Boot] [PATCH v1 05/25] spi: kirkwood_spi.c: cosmetic: Fix minor coding style issues Stefan Roese
2014-07-03 20:18 ` Jagan Teki
2014-06-27 9:54 ` [U-Boot] [PATCH v1 06/25] arm: kirkwood: Move some SoC files into new arch/arm/mvebu-common Stefan Roese
2014-06-27 9:54 ` [U-Boot] [PATCH v1 07/25] arm: marvell: Move arch/kirkwood.h to arch/soc.h Stefan Roese
2014-06-27 9:54 ` [U-Boot] [PATCH v1 08/25] arm: marvell: Move arch-kirkwood/spi.h to arch-mvebu/spi.h Stefan Roese
2014-07-13 16:16 ` Jagan Teki
2014-06-27 9:54 ` [U-Boot] [PATCH v1 09/25] arm: marvell: Rework timer.c to make it usable for other MVEBU platforms Stefan Roese
2014-06-27 9:54 ` [U-Boot] [PATCH v1 10/25] arm: mvebu: Add common mbus functions to use on Marvell SoCs Stefan Roese
2014-06-27 9:54 ` [U-Boot] [PATCH v1 11/25] spi: kirkwood_spi.c: Compile MPP (pin-mux) only for kirkwood SoC's Stefan Roese
2014-07-13 16:18 ` Jagan Teki
2014-06-27 9:54 ` [U-Boot] [PATCH v1 12/25] arm: marvell: Extract kirkwood gpio functions into new common file gpio.c Stefan Roese
2014-06-27 9:54 ` [U-Boot] [PATCH v1 13/25] spi: kirkwood_spi.c: Change KW_SPI_BASE to MVEBU_SPI_BASE Stefan Roese
2014-07-13 16:18 ` Jagan Teki
2014-06-27 9:55 ` [U-Boot] [PATCH v1 14/25] arm: kirkwood: Change naming of dram functions from km_foo() to mvebu_foo() Stefan Roese
2014-06-27 9:55 ` [U-Boot] [PATCH v1 15/25] net: mvneta.c: Add support for the ethernet controller of the Marvell Armada XP SoC Stefan Roese
2014-06-27 9:55 ` [U-Boot] [PATCH v1 16/25] net: phy.h: Make PHY autonegotiation timeout configurable Stefan Roese
2014-06-27 9:55 ` [U-Boot] [PATCH v1 17/25] i2c: mvtwsi: Add support for Marvell Armada XP Stefan Roese
2014-07-01 5:48 ` Heiko Schocher
2014-06-27 9:55 ` [U-Boot] [PATCH v1 18/25] arm: armada-xp: Add basic support for Marvell Armada XP SoC Stefan Roese
2014-06-27 9:55 ` [U-Boot] [PATCH v1 19/25] arm: armada-xp: Add basic support for the Marvell DB-78460-BP board Stefan Roese
2014-06-27 9:55 ` [U-Boot] [PATCH v1 20/25] arm: kirkwood: Remove some dead code from cpu.c Stefan Roese
2014-07-01 23:45 ` Luka Perkov
2014-06-27 9:55 ` [U-Boot] [PATCH v1 21/25] arm: kirkwood: Use mvebu new common mbus API Stefan Roese
2014-06-27 9:55 ` [U-Boot] [PATCH v1 22/25] tools/kwboot: Sync with latest barebox version to support Armada XP Stefan Roese
2014-06-27 19:06 ` Luka Perkov
2014-06-28 1:25 ` Daniel Stodden
2014-06-28 7:43 ` Stefan Roese
2014-07-03 22:02 ` Luka Perkov
2014-07-28 6:47 ` Stefan Roese [this message]
2014-07-29 23:16 ` Luka Perkov
2014-07-30 8:53 ` Stefan Roese
2014-07-28 8:12 ` Wolfgang Denk
2014-06-27 9:55 ` [U-Boot] [PATCH v1 23/25] tools: Compile kwboot for Marvell Armada XP as those SoCs are now supported Stefan Roese
2014-07-03 22:03 ` Luka Perkov
2014-06-27 9:55 ` [U-Boot] [PATCH v1 24/25] tools: kwbimage: Add image version 1 support for Armada XP / 370 Stefan Roese
2014-07-03 22:03 ` Luka Perkov
2014-06-27 9:55 ` [U-Boot] [PATCH v1 25/25] Makefile: Add CONFIG_BUILD_TARGET to automatically build an special image Stefan Roese
2014-06-27 10:18 ` [U-Boot] [PATCH v1 0/25] Add Marvell Armada XP MV78460 SoC support Prafulla Wadaskar
2014-07-13 16:15 ` Jagan Teki
2014-07-14 14:51 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D5F1F1.9070403@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox