From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 10/12] odroid: add board file for Odroid X2/U3 based on Samsung Exynos4412
Date: Mon, 28 Jul 2014 10:29:22 +0200 [thread overview]
Message-ID: <53D609E2.6070807@samsung.com> (raw)
In-Reply-To: <CALrBrZ0AayLhCn8CEBTyD7tZ85W2--kNefrcx3M-i3sdevqyPQ@mail.gmail.com>
Hello Minkyu,
On 07/26/2014 11:07 AM, Minkyu Kang wrote:
> Dear Przemyslaw Marczak,
>
>
> On 19 July 2014 00:29, Przemyslaw Marczak <p.marczak@samsung.com
> <mailto:p.marczak@samsung.com>> wrote:
>
> This board file supports standard features of Odroid X2 and U3 boards:
> - Exynos4412 core clock set to 1000MHz and MPLL peripherial clock
> set to 800MHz,
> - MAX77686 power regulator,
> - USB PHY,
> - enable XCL205 - power for board peripherials
> - check board type: U3 or X2.
> - enable Odroid U3 FAN cooler
>
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com
> <mailto:p.marczak@samsung.com>>
> Cc: Minkyu Kang <mk7.kang at samsung.com <mailto:mk7.kang@samsung.com>>
> Cc: Tom Rini <trini at ti.com <mailto:trini@ti.com>>
>
> ---
> Changes v2:
> - enable fan on odroid U3
>
> Changes v3:
> - odroid.c: clean up board name related code
> - odroid.c: remove static from set_board_type()
> - odroid.c: add implementation of functions: get_dfu_alt_*
> - odroid.c: include misc.h
>
> Changes v4:
> - odroid.c: dfu_get_alt_boot: add call get_boot_mode()
>
> Changes v5:
> - odroid.c: set_board_type: change mdelay to sdelay, define XCL205
> GPIO config
> - odroid.c: board_gpio_init(): fix OTG for Odroid U3+
> - odroid.c: reserve the last 1 MB of dram for secure firmware
> - odroid.c: board_clock_init(): code cleanup
> - odroid.c: get_dfu_alt_boot(): remove setenv()
> - odroid.c: remove get_board_name() function definition
> - odroid.c: add enum ODROID_TYPES
> ---
> board/samsung/odroid/Makefile | 8 +
> board/samsung/odroid/odroid.c | 470
> ++++++++++++++++++++++++++++++++++++++++++
> board/samsung/odroid/setup.h | 255 +++++++++++++++++++++++
> 3 files changed, 733 insertions(+)
> create mode 100644 board/samsung/odroid/Makefile
> create mode 100644 board/samsung/odroid/odroid.c
> create mode 100644 board/samsung/odroid/setup.h
>
> diff --git a/board/samsung/odroid/setup.h b/board/samsung/odroid/setup.h
> new file mode 100644
> index 0000000..f6acbff
> --- /dev/null
> +++ b/board/samsung/odroid/setup.h
> @@ -0,0 +1,255 @@
> +/*
> + * Copyright (C) 2014 Samsung Electronics
> + * Przemyslaw Marczak <p.marczak@samsung.com
> <mailto:p.marczak@samsung.com>>
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +
> +#ifndef __ODROIDU3_SETUP__
> +#define __ODROIDU3_SETUP__
> +
> +/* A/M PLL_CON0 */
> +#define SDIV(x) (x & 0x7)
>
>
> In this file, x should be wrapped with ().
> Please fix it.
Ok, I will fix this.
>
> +#define PDIV(x) ((x & 0x3f) << 8)
> +#define MDIV(x) ((x & 0x3ff) << 16)
> +#define FSEL(x) ((x & 0x1) << 27)
> +#define PLL_LOCKED_BIT (0x1 << 29)
> +#define PLL_ENABLE(x) ((x & 0x1) << 31)
> +
> +/* CLK_SRC_CPU */
> +#define MUX_APLL_SEL(x) (x & 0x1)
> +#define MUX_CORE_SEL(x) ((x & 0x1) << 16)
> +#define MUX_HPM_SEL(x) ((x & 0x1) << 20)
> +#define MUX_MPLL_USER_SEL_C(x) ((x & 0x1) << 24)
> +
>
>
> Others are looks good to me.
>
> Thanks,
> Minkyu Kang.
>
> --
> from. prom.
> www.promsoft.net <http://www.promsoft.net>
Thank you,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
next prev parent reply other threads:[~2014-07-28 8:29 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 13:09 [U-Boot] [PATCH v5 00/12] Add support to Odroid U3/X2 Przemyslaw Marczak
2014-07-17 13:09 ` [U-Boot] [PATCH v5 01/12] samsung: misc: fix soc revision setting in the set_board_info() Przemyslaw Marczak
2014-07-17 13:09 ` [U-Boot] [PATCH v5 02/12] exynos: pinmux: fix the gpio names for exynos4x12 mmc Przemyslaw Marczak
2014-07-17 13:09 ` [U-Boot] [PATCH v5 03/12] arch:exynos: boot mode: add get_boot_mode(), code cleanup Przemyslaw Marczak
2014-07-17 13:09 ` [U-Boot] [PATCH v5 04/12] board:samsung: check the boot device and init the right mmc driver Przemyslaw Marczak
2014-07-17 13:09 ` [U-Boot] [PATCH v5 05/12] samsung: misc: add function for setting $dfu_alt_info Przemyslaw Marczak
2014-07-17 13:09 ` [U-Boot] [PATCH v5 06/12] samsung:board: misc_init_r: call set_dfu_alt_info() Przemyslaw Marczak
2014-07-17 13:09 ` [U-Boot] [PATCH v5 07/12] arm:reset: call the reset_misc() before the cpu reset Przemyslaw Marczak
2014-07-17 13:09 ` [U-Boot] [PATCH v5 08/12] samsung: board: enable support of multiple board types Przemyslaw Marczak
2014-07-17 13:09 ` [U-Boot] [PATCH v5 09/12] samsung: misc: use board specific functions to set env board info Przemyslaw Marczak
2014-07-17 13:09 ` [U-Boot] [PATCH v5 10/12] odroid: add board file for Odroid X2/U3 based on Samsung Exynos4412 Przemyslaw Marczak
2014-07-17 13:09 ` [U-Boot] [PATCH v5 11/12] odroid: add odroid U3/X2 device tree description Przemyslaw Marczak
2014-07-17 13:09 ` [U-Boot] [PATCH v5 12/12] odroid: add odroid_config Przemyslaw Marczak
2014-07-18 15:29 ` [U-Boot] [PATCH v6 00/12] Add support to Odroid U3/X2 Przemyslaw Marczak
2014-07-18 15:29 ` [U-Boot] [PATCH v6 01/12] samsung: misc: fix soc revision setting in the set_board_info() Przemyslaw Marczak
2014-07-18 15:29 ` [U-Boot] [PATCH v6 02/12] exynos: pinmux: fix the gpio names for exynos4x12 mmc Przemyslaw Marczak
2014-07-18 15:29 ` [U-Boot] [PATCH v6 03/12] arch:exynos: boot mode: add get_boot_mode(), code cleanup Przemyslaw Marczak
2014-07-28 5:10 ` Jaehoon Chung
2014-07-28 8:26 ` Przemyslaw Marczak
2014-07-18 15:29 ` [U-Boot] [PATCH v6 04/12] board:samsung: check the boot device and init the right mmc driver Przemyslaw Marczak
2014-07-18 15:29 ` [U-Boot] [PATCH v6 05/12] samsung: misc: add function for setting $dfu_alt_info Przemyslaw Marczak
2014-07-18 15:29 ` [U-Boot] [PATCH v6 06/12] samsung:board: misc_init_r: call set_dfu_alt_info() Przemyslaw Marczak
2014-07-18 15:29 ` [U-Boot] [PATCH v6 07/12] arm:reset: call the reset_misc() before the cpu reset Przemyslaw Marczak
2014-07-18 15:29 ` [U-Boot] [PATCH v6 08/12] samsung: board: enable support of multiple board types Przemyslaw Marczak
2014-07-18 15:29 ` [U-Boot] [PATCH v6 09/12] samsung: misc: use board specific functions to set env board info Przemyslaw Marczak
2014-07-18 15:29 ` [U-Boot] [PATCH v6 10/12] odroid: add board file for Odroid X2/U3 based on Samsung Exynos4412 Przemyslaw Marczak
2014-07-26 9:07 ` Minkyu Kang
2014-07-28 8:29 ` Przemyslaw Marczak [this message]
2014-07-18 15:29 ` [U-Boot] [PATCH v6 11/12] odroid: add odroid U3/X2 device tree description Przemyslaw Marczak
2014-07-18 15:29 ` [U-Boot] [PATCH v6 12/12] odroid: add odroid_config Przemyslaw Marczak
2014-07-30 11:35 ` [U-Boot] [PATCH v7 00/12] Add support to Odroid U3/X2 Przemyslaw Marczak
2014-07-30 11:35 ` [U-Boot] [PATCH v7 01/12] samsung: misc: fix soc revision setting in the set_board_info() Przemyslaw Marczak
2014-07-30 11:35 ` [U-Boot] [PATCH v7 02/12] exynos: pinmux: fix the gpio names for exynos4x12 mmc Przemyslaw Marczak
2014-07-30 11:35 ` [U-Boot] [PATCH v7 03/12] arch:exynos: boot mode: add get_boot_mode(), code cleanup Przemyslaw Marczak
2014-07-30 11:35 ` [U-Boot] [PATCH v7 04/12] board:samsung: check the boot device and init the right mmc driver Przemyslaw Marczak
2014-07-30 11:35 ` [U-Boot] [PATCH v7 05/12] samsung: misc: add function for setting $dfu_alt_info Przemyslaw Marczak
2014-07-30 11:35 ` [U-Boot] [PATCH v7 06/12] samsung:board: misc_init_r: call set_dfu_alt_info() Przemyslaw Marczak
2014-07-30 11:35 ` [U-Boot] [PATCH v7 07/12] arm:reset: call the reset_misc() before the cpu reset Przemyslaw Marczak
2014-07-30 11:35 ` [U-Boot] [PATCH v7 08/12] samsung: board: enable support of multiple board types Przemyslaw Marczak
2014-07-30 11:35 ` [U-Boot] [PATCH v7 09/12] samsung: misc: use board specific functions to set env board info Przemyslaw Marczak
2014-07-30 11:35 ` [U-Boot] [PATCH v7 10/12] odroid: add board file for Odroid X2/U3 based on Samsung Exynos4412 Przemyslaw Marczak
2014-07-30 11:35 ` [U-Boot] [PATCH v7 11/12] odroid: add odroid U3/X2 device tree description Przemyslaw Marczak
2014-07-30 11:35 ` [U-Boot] [PATCH v7 12/12] odroid: add odroid_config Przemyslaw Marczak
2014-09-01 11:50 ` [U-Boot] [PATCH v8 00/12] Add support to Odroid U3/X2 Przemyslaw Marczak
2014-09-01 11:50 ` [U-Boot] [PATCH v8 01/12] samsung: misc: fix soc revision setting in the set_board_info() Przemyslaw Marczak
2014-09-01 11:50 ` [U-Boot] [PATCH v8 02/12] exynos: pinmux: fix the gpio names for exynos4x12 mmc Przemyslaw Marczak
2014-09-01 11:50 ` [U-Boot] [PATCH v8 03/12] arch:exynos: boot mode: add get_boot_mode(), code cleanup Przemyslaw Marczak
2014-09-01 11:50 ` [U-Boot] [PATCH v8 04/12] board:samsung: check the boot device and init the right mmc driver Przemyslaw Marczak
2014-09-01 11:50 ` [U-Boot] [PATCH v8 05/12] samsung: misc: add function for setting $dfu_alt_info Przemyslaw Marczak
2014-09-01 11:50 ` [U-Boot] [PATCH v8 06/12] samsung:board: misc_init_r: call set_dfu_alt_info() Przemyslaw Marczak
2014-09-01 11:50 ` [U-Boot] [PATCH v8 07/12] arm:reset: call the reset_misc() before the cpu reset Przemyslaw Marczak
2014-09-01 11:50 ` [U-Boot] [PATCH v8 08/12] samsung: board: enable support of multiple board types Przemyslaw Marczak
2014-09-01 11:50 ` [U-Boot] [PATCH v8 09/12] samsung: misc: use board specific functions to set env board info Przemyslaw Marczak
2014-09-01 11:50 ` [U-Boot] [PATCH v8 10/12] odroid: add board file for Odroid X2/U3 based on Samsung Exynos4412 Przemyslaw Marczak
2014-09-01 11:50 ` [U-Boot] [PATCH v8 11/12] odroid: add odroid U3/X2 device tree description Przemyslaw Marczak
2014-09-01 11:50 ` [U-Boot] [PATCH v8 12/12] odroid: kconfig: add odroid_defconfig Przemyslaw Marczak
2014-09-01 12:02 ` [U-Boot] [PATCH v8 00/12] Add support to Odroid U3/X2 Przemyslaw Marczak
2014-09-05 6:34 ` Minkyu Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D609E2.6070807@samsung.com \
--to=p.marczak@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox