public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jeroen Hofstee <jeroen@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] env_mmc: support env partition setup in runtime
Date: Tue, 29 Jul 2014 19:44:23 +0200	[thread overview]
Message-ID: <53D7DD77.8080305@myspectrum.nl> (raw)
In-Reply-To: <1406627169-21616-1-git-send-email-lifshitz@compulab.co.il>

Hello Dmitry,

On 29-07-14 11:46, Dmitry Lifshitz wrote:
> Add callback with __weak annotation to allow setup of environment
> partition number in runtime from a board file.
>
> Propagate mmc_switch_part() return value into init_mmc_for_env() instead
> of -1 in case of failure.
>
> Signed-off-by: Dmitry Lifshitz <lifshitz@compulab.co.il>
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
>   common/env_mmc.c |   35 +++++++++++++++++++++++------------
>   1 files changed, 23 insertions(+), 12 deletions(-)
>
> diff --git a/common/env_mmc.c b/common/env_mmc.c
> index 7da10e6..a7621a8 100644
> --- a/common/env_mmc.c
> +++ b/common/env_mmc.c
> @@ -62,16 +62,36 @@ int env_init(void)
>   	return 0;
>   }
>   
> -static int init_mmc_for_env(struct mmc *mmc)
> -{
>   #ifdef CONFIG_SYS_MMC_ENV_PART
> +__weak uint mmc_get_env_part(struct mmc *mmc)
> +{
> +	return CONFIG_SYS_MMC_ENV_PART;
> +}
> +

mmc_get_env_part lacks a prototype and there seems to be no
"strong version" / user of this code.

Regards,
Jeroen

  reply	other threads:[~2014-07-29 17:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29  9:46 [U-Boot] [PATCH 1/1] env_mmc: support env partition setup in runtime Dmitry Lifshitz
2014-07-29 17:44 ` Jeroen Hofstee [this message]
2014-07-30  6:15   ` Igor Grinberg
2014-07-30 10:19 ` [U-Boot] [PATCH 1/2] env_mmc: add mmc_get_env_addr() prototype Dmitry Lifshitz
2014-07-30 10:19   ` [U-Boot] [PATCH v2 2/2] env_mmc: support env partition setup in runtime Dmitry Lifshitz
2014-08-01 17:14     ` Pantelis Antoniou
2014-08-01 17:14   ` [U-Boot] [PATCH 1/2] env_mmc: add mmc_get_env_addr() prototype Pantelis Antoniou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D7DD77.8080305@myspectrum.nl \
    --to=jeroen@myspectrum.nl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox