public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] Makefile: Add a message warning size change for mpc85xx boards
Date: Tue, 29 Jul 2014 14:56:46 -0700	[thread overview]
Message-ID: <53D8189E.2020607@freescale.com> (raw)
In-Reply-To: <1406669019-31651-1-git-send-email-yorksun@freescale.com>

This is an RFC. Do NOT apply. It outputs the message, tricks MAKEALL to count it
as warning.

York


On 07/29/2014 02:23 PM, York Sun wrote:
> Some mpc85xx boards are using 768KB size u-boot image while some
> legacy boards still use 512KB. To bring attention to users about
> the size change, a message is printed when compiling. SPL/PBL is
> not covered by this change.
> 
> Signed-off-by: York Sun <yorksun@freescale.com>
> CC: Kim Phillips <kim.phillips@freescale.com>
> ---
>  Makefile |   12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index ca212b5..5c823dc 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -691,8 +691,20 @@ BOARD_SIZE_CHECK = \
>  		exit 1; \
>  	fi
>  else
> +ifdef CONFIG_MPC85xx
> +BOARD_SIZE_CHECK = \
> +	@actual=`wc -c $@ | awk '{print $$1}'`; \
> +	limit=524288; \
> +	if test $$actual -gt $$limit; then \
> +		echo "Attention: File size $$actual bytes, may be different from legacy images" >&2; \
> +		offset=`printf "%x" $$actual`; \
> +		echo "           NOR flash address for u-boot.bin: 0x$$offset from end of boot bank" >&2; \
> +		echo "           See board README"; \
> +	fi
> +else
>  BOARD_SIZE_CHECK =
>  endif
> +endif
>  
>  # Statically apply RELA-style relocations (currently arm64 only)
>  ifneq ($(CONFIG_STATIC_RELA),)
> 

  reply	other threads:[~2014-07-29 21:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29 21:23 [U-Boot] [RFC] Makefile: Add a message warning size change for mpc85xx boards York Sun
2014-07-29 21:56 ` York Sun [this message]
2014-07-30  5:02 ` Wolfgang Denk
2014-07-30 22:13   ` York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D8189E.2020607@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox