public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings
Date: Thu, 31 Jul 2014 13:57:12 -0600	[thread overview]
Message-ID: <53DA9F98.9050506@wwwdotorg.org> (raw)
In-Reply-To: <20140731195130.GT19374@bill-the-cat>

On 07/31/2014 01:51 PM, Tom Rini wrote:
> On Wed, Jul 30, 2014 at 04:47:57PM -0600, Stephen Warren wrote:
>
>> On 07/14/2014 09:49 AM, Alexander Holler wrote:
>>> When this option is enabled, CRLF is treated like LF when importing environments
>> >from text files, which means CRs ('\r') in front of LFs ('\n') are just ignored.
>>>
>>> Drawback of enabling this option is that (maybe exported) variables which have
>>> a trailing CR in their content will get imported without that CR. But this
>>> drawback is very unlikely and the big advantage of letting Windows user create
>>> a *working* uEnv.txt too is likely more welcome.
>>
>> This patch doesn't seem to have been applied, yet patches 2..4 in
>> the series were. This means that various boot scripts use "env
>> import -t -r ..." which fails due to the unknown option -r...
>
> commit ecd1446fe1df00d7f7b9de286dba309d93b51870
> Author: Alexander Holler <holler@ahsoftware.de>
> Date:   Mon Jul 14 17:49:55 2014 +0200
>
> Add option -r to env import to allow import of text files with CRLF as line
>
> is what I have.

Huh, I do see that now. I must have been looking at the content of 
common/cmd_nvedit.c from the wrong branch, which didn't include that 
patch. I could have sworn I checked git history too, but evidently not. 
It is indeed clearly there right before the patches which use it. Sorry 
for the noise.

  reply	other threads:[~2014-07-31 19:57 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 15:49 [U-Boot] [PATCH 0/4] Add option -r to env import to allow import of text files with CRLF as line endings Alexander Holler
2014-07-14 15:49 ` [U-Boot] [PATCH 1/4] " Alexander Holler
2014-07-22 19:23   ` [U-Boot] [U-Boot, " Tom Rini
2014-07-30 22:47   ` [U-Boot] [PATCH " Stephen Warren
2014-07-31 19:51     ` Tom Rini
2014-07-31 19:57       ` Stephen Warren [this message]
2014-08-14  8:25         ` Alexander Holler
2014-08-14 15:49           ` Stephen Warren
2014-08-14 18:41             ` Robert Nelson
2014-08-14 19:38               ` Tom Rini
2014-08-14 19:50               ` Stephen Warren
2014-08-14 20:53                 ` Tom Rini
2014-08-14 21:05                   ` Alexander Holler
2014-08-14 21:35                   ` Stephen Warren
2014-08-14 21:44                     ` Alexander Holler
2014-08-14 19:38             ` Alexander Holler
2014-08-14 19:51               ` Stephen Warren
2014-08-14 19:59                 ` Alexander Holler
2014-08-14 20:08                   ` Stephen Warren
2014-08-14 20:39                     ` Alexander Holler
2014-08-01 12:08   ` Wolfgang Denk
2014-08-02 21:09     ` Alexander Holler
2014-08-03 16:38       ` Alexander Holler
2014-08-03 17:51         ` Wolfgang Denk
2014-08-04  6:47           ` Alexander Holler
2014-08-04  7:00             ` Alexander Holler
2014-08-04 10:00             ` Måns Rullgård
2014-08-04 19:18               ` Alexander Holler
2014-08-06  6:43                 ` Wolfgang Denk
2014-08-06 10:02                   ` Alexander Holler
2014-08-06 10:28                     ` Alexander Holler
2014-08-06 10:44                     ` Måns Rullgård
2014-08-06 11:18                       ` Alexander Holler
2014-08-06 11:48                         ` Alexander Holler
2014-08-03 17:47       ` Wolfgang Denk
2014-07-14 15:49 ` [U-Boot] [PATCH 2/4] omap3_beagle: handle import of environments in " Alexander Holler
2014-07-22 19:23   ` [U-Boot] [U-Boot, " Tom Rini
2014-07-14 15:49 ` [U-Boot] [PATCH 3/4] am335x_evm: " Alexander Holler
2014-07-22 19:23   ` [U-Boot] [U-Boot, " Tom Rini
2014-07-14 15:49 ` [U-Boot] [PATCH 4/4] rpi_b: " Alexander Holler
2014-07-22 19:23   ` [U-Boot] [U-Boot, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DA9F98.9050506@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox