From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Thu, 31 Jul 2014 14:16:56 -0600
Subject: [U-Boot] [PATCH v3 14/16] tegra: dts: Add serial port details
In-Reply-To: <1406713793-12828-15-git-send-email-sjg@chromium.org>
References: <1406713793-12828-1-git-send-email-sjg@chromium.org>
	<1406713793-12828-15-git-send-email-sjg@chromium.org>
Message-ID: <53DAA438.9080405@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 07/30/2014 03:49 AM, Simon Glass wrote:
> Some Tegra device tree files do not include information about the serial
> ports. Add this and also add information about the input clock speed.
>
> The console alias needs to be set up to indicate which port is used for
> the console.
>
> Also add a binding file since this is missing.

> diff --git a/arch/arm/dts/tegra114-dalmore.dts b/arch/arm/dts/tegra114-dalmore.dts
> index 435c01e..e2426ef 100644
> --- a/arch/arm/dts/tegra114-dalmore.dts
> +++ b/arch/arm/dts/tegra114-dalmore.dts
> @@ -7,6 +7,7 @@
>   	compatible = "nvidia,dalmore", "nvidia,tegra114";
>
>   	aliases {
> +		console = &uart_d;

I don't think that's a standard alias name. There was some recent 
discussion in the devicetree mailing list re: using some property in 
/chosen for this purpose instead. U-Boot and the kernel should use the 
same representation here.

> diff --git a/arch/arm/dts/tegra114.dtsi b/arch/arm/dts/tegra114.dtsi

> +	uart_a: serial at 70006000 {
> +		compatible = "nvidia,tegra20-uart";

This property needs to include both the specific HW (i.e. Tegra114) and 
any HW it's compatible with (i.e. Tegra20).

> +		reg = <0x70006000 0x40>;
> +		reg-shift = <2>;
> +		clock-frequency = <408000000>;

This isn't a property that's defined by the Tegra serial binding. This 
information should be obtained by looking up the relevant clock, and 
querying its rate.

> +		interrupts = < 68 >;
> +	};

For reference, here's the DT node for this UART in the kernel DT, which 
complies with the relevant binding document:

         uarta: serial at 70006000 {
                 compatible = "nvidia,tegra114-uart", "nvidia,tegra20-uart";
                 reg = <0x70006000 0x40>;
                 reg-shift = <2>;
                 interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>;
                 clocks = <&tegra_car TEGRA114_CLK_UARTA>;
                 resets = <&tegra_car 6>;
                 reset-names = "serial";
                 dmas = <&apbdma 8>, <&apbdma 8>;
                 dma-names = "rx", "tx";
                 status = "disabled";
         };

All the comment above apply to all the files in this patch.