From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Thu, 31 Jul 2014 14:18:50 -0600
Subject: [U-Boot] [PATCH v3 15/16] RFC: dm: tegra: Enable driver model
	for serial
In-Reply-To: <1406713793-12828-16-git-send-email-sjg@chromium.org>
References: <1406713793-12828-1-git-send-email-sjg@chromium.org>
	<1406713793-12828-16-git-send-email-sjg@chromium.org>
Message-ID: <53DAA4AA.8050004@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 07/30/2014 03:49 AM, Simon Glass wrote:
> Use driver model for serial ports (for test and comment only).

A couple of nits:

> diff --git a/include/configs/tegra-common.h b/include/configs/tegra-common.h

>   #define CONFIG_SYS_MALLOC_LEN		(4 << 20)	/* 4MB  */
> +#define CONFIG_SYS_MALLOC_F_LEN	(1 << 10)

README says:

                 Pre-relocation malloc() is only supported on sandbox
                @present but is fairly easy to enable for other archs.

I assume that should be deleted now.

>
>   /*
>    * NS16550 Configuration
>    */
> -#define CONFIG_SYS_NS16550
> +#ifdef CONFIG_SPL_BUILD
>   #define CONFIG_SYS_NS16550_SERIAL
>   #define CONFIG_SYS_NS16550_REG_SIZE	(-4)
>   #define CONFIG_SYS_NS16550_CLK		V_NS16550_CLK
> +#endif
> +#define CONFIG_SYS_NS16550

Leaving that define in the same place would simplify the diff.