From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Thu, 31 Jul 2014 14:20:46 -0600
Subject: [U-Boot] [PATCH v3 07/16] sandbox: dts: Add a serial console
	node
In-Reply-To: <1406713793-12828-8-git-send-email-sjg@chromium.org>
References: <1406713793-12828-1-git-send-email-sjg@chromium.org>
	<1406713793-12828-8-git-send-email-sjg@chromium.org>
Message-ID: <53DAA51E.6030804@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 07/30/2014 03:49 AM, Simon Glass wrote:
> If the sandbox device tree is provided to U-Boot (with the -d flag) then it
> will use the device tree version in preference to the built-in device. The
> only difference is the colour.

> diff --git a/arch/sandbox/dts/sandbox.dts b/arch/sandbox/dts/sandbox.dts

> +	uart0: serial {
> +		compatible = "sandbox,serial";
> +		u-boot,dm-pre-reloc;

Shouldn't that be handled by the driver. It's certainly something that's 
only relevant to the internals of U-Boot, and hence inappropriate to put 
into DT.

> +		text-colour = "cyan";

That's property should likely have a uboot, prefix, since it's non-standard.