public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pxe: automatically add console= to bootargs when not specified in append
Date: Fri, 01 Aug 2014 10:20:04 +0200	[thread overview]
Message-ID: <53DB4DB4.5060704@redhat.com> (raw)
In-Reply-To: <1406879180-12278-1-git-send-email-hdegoede@redhat.com>

Hi,

On 08/01/2014 09:46 AM, Hans de Goede wrote:
> From: Dennis Gilmore <dennis@ausil.us>
> 
> if there is a console variable in the u-boot environment and not one on
> the append line from syslinux config add what is in the environment to
> the bootargs.
> 
> This is necessary to allow distros to have a single extlinux/extlinux.conf
> file which will work on multiple boards, even if these boards have different
> consoles (e.g. ttyS0 vs ttyAMA0).
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

I asked Dennis for its Signed-off-by for this, and instead I got this:

> NAK, I was planning to drop the patch entirely, while its useful in
> some cases, it breaks things like plymouth working, as well it will
> force anaconda installs to always be text over the serial port.
> wandboard and cubox-i for instance boot happily without a console= line
> and you get plymouth on the screen when video is initialised. having it
> add the console line if u-boot has the console set to serial would be
> okay. I think it needs some more thought and careful planning.
>
> Dennis

So lets drop this one for now.

Regards,

Hans

  reply	other threads:[~2014-08-01  8:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01  7:46 [U-Boot] [PATCH] pxe: automatically add console= to bootargs when not specified in append Hans de Goede
2014-08-01  8:20 ` Hans de Goede [this message]
2014-08-01  8:35   ` Hans de Goede
2014-08-01 19:01 ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DB4DB4.5060704@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox