From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] bootm: use genimg_get_kernel_addr()
Date: Fri, 01 Aug 2014 13:18:09 -0600 [thread overview]
Message-ID: <53DBE7F1.4050905@wwwdotorg.org> (raw)
In-Reply-To: <1406853600-30615-4-git-send-email-pengw@nvidia.com>
On 07/31/2014 06:40 PM, Bryan Wu wrote:
> Use the new API which is originally taken out from boot_get_kernel
> of bootm.c
> diff --git a/common/bootm.c b/common/bootm.c
> case IMAGE_FORMAT_FIT:
> + if (!fit_parse_conf(argv[0], load_addr, &img_addr,
> + fit_uname_config))
> + fit_parse_subimage(argv[0], load_addr, &img_addr,
> + fit_uname_kernel);
I'd be tempted to try and rework patch 1/3 so that it could "return" the
fit_uname_* values too. That way, you wouldn't need to call
fit_parse_*() a second time here. This probably isn't a big issue though.
The series,
Tested-by: Stephen Warren <swarren@nvidia.com>
Reviewed-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2014-08-01 19:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 0:39 [U-Boot] [PATCH 0/3] introduce genimg_get_kernel_addr() Bryan Wu
2014-08-01 0:39 ` [U-Boot] [PATCH 1/3] image: " Bryan Wu
2014-08-04 10:15 ` Simon Glass
2014-08-10 22:21 ` [U-Boot] [U-Boot, " Tom Rini
2014-08-12 17:27 ` Bryan Wu
2014-08-01 0:39 ` [U-Boot] [PATCH 2/3] pxe: detect image format before calling bootm/bootz Bryan Wu
2014-08-10 22:21 ` [U-Boot] [U-Boot, " Tom Rini
2014-08-01 0:40 ` [U-Boot] [PATCH 3/3] bootm: use genimg_get_kernel_addr() Bryan Wu
2014-08-01 19:18 ` Stephen Warren [this message]
2014-08-05 0:46 ` Bryan Wu
2014-08-04 10:22 ` Simon Glass
2014-08-10 22:21 ` [U-Boot] [U-Boot,3/3] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DBE7F1.4050905@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox