From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Fri, 01 Aug 2014 15:52:13 -0600 Subject: [U-Boot] [PATCH v3 07/16] sandbox: dts: Add a serial console node In-Reply-To: References: <1406713793-12828-1-git-send-email-sjg@chromium.org> <1406713793-12828-8-git-send-email-sjg@chromium.org> <53DAA51E.6030804@wwwdotorg.org> <53DACCB8.2030206@wwwdotorg.org> Message-ID: <53DC0C0D.1010305@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/01/2014 03:40 PM, Simon Glass wrote: > Hi Stephen, > > On 1 August 2014 00:09, Stephen Warren wrote: >> On 07/31/2014 04:13 PM, Simon Glass wrote: >>> >>> Hi Stephen, >>> >>> On 31 July 2014 21:20, Stephen Warren wrote: >>>> >>>> On 07/30/2014 03:49 AM, Simon Glass wrote: >>>>> >>>>> >>>>> If the sandbox device tree is provided to U-Boot (with the -d flag) then it >>>>> will use the device tree version in preference to the built-in device. The >>>>> only difference is the colour. >>>> >>>>> diff --git a/arch/sandbox/dts/sandbox.dts b/arch/sandbox/dts/sandbox.dts >>>>> + uart0: serial { >>>>> + compatible = "sandbox,serial"; >>>>> + u-boot,dm-pre-reloc; >>>> ... >>>>> + text-colour = "cyan"; >>>> >>>> >>>> >>>> That's property should likely have a uboot, prefix, since it's >>>> non-standard. >>> >>> Can I not just declare a binding for 'sandbox,serial'? >> >> Properties that are relevant only to a particular binding, rather than being >> something quite generic an applicable to a whole class of devices, typically >> have a vendor prefix. >> >> A binding should/must exist for every node or compatible value. So, whether >> you actually write the binding document or not makes no difference to the >> names or vendor prefixes of the properties the binding uses. > > So here you are saying it should be: > > sandbox,text-colour = "cyan"; > > Is that right? I think that sounds right yes.