public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH v2 0/2] Make Python scripts compatible with older versions
Date: Mon, 04 Aug 2014 14:21:32 +0300	[thread overview]
Message-ID: <53DF6CBC.8040701@compulab.co.il> (raw)
In-Reply-To: <1407147794-32066-1-git-send-email-yamada.m@jp.panasonic.com>

Hi Masahiro,


On 08/04/14 13:23, Masahiro Yamada wrote:
> 
> It was reported by Miao Yan that the kconfig-related Python scripts
> are not working on Python 2.4.
> 
> Do we have any consensus in terms of Python version requirement?
> 
> This series avoids using "with ... as ..." and "except ... as ..."
> statements.  But "with ... as ..." is used everywhere in buildman,
> which means buildman requires at least Python 2.6.

Hmmmm.... Funny... a bit more fire:

-------------------cut----------------------------
$ make cm_t335_defconfig
  HOSTCC  scripts/basic/fixdep
  GEN     /home/grinberg/bin-temp/u-boot/Makefile
  File "/home/grinberg/git-repo/u-boot/scripts/multiconfig.py", line 344
    print "*** Default configuration is based on '%s'" % KBUILD_DEFCONFIG
                                                     ^
SyntaxError: invalid syntax
make[1]: *** [cm_t335_defconfig] Error 1
make: *** [sub-make] Error 2

$ python --version
Python 3.3.5
-------------------cut----------------------------

Apparently, print should be used as function - with parenthesis...
It seems that those scripts only work on Python versions 2.6 - 2.7?

> 
> It is true we hope tools can work on broad range of versions,
> but it also means we have more restrictions when writing Python scripts.
> 
> I have no idea which version we should expect at least.
> Your comments are welcome.

I'd propose to not bring any new dependency on python at all...
At least not for the simple task of building U-Boot...
Can't we use a bit more stable API then this of python?

> 
> 
> Changes in v2:
>   - Fix git-description.  s/exception/except/
>   - Fix git-description.  s/exception/except/
> 
> Masahiro Yamada (2):
>   kconfig: make multiconfig.py compatible with Python 2.4
>   tools: make genboardscfg.py compatible with Python 2.5
> 
>  scripts/multiconfig.py | 73 +++++++++++++++++++++++---------------------------
>  tools/genboardscfg.py  |  4 +--
>  2 files changed, 36 insertions(+), 41 deletions(-)
> 

-- 
Regards,
Igor.

  parent reply	other threads:[~2014-08-04 11:21 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04 10:23 [U-Boot] [RFC PATCH v2 0/2] Make Python scripts compatible with older versions Masahiro Yamada
2014-08-04 10:23 ` [U-Boot] [RFC PATCH v2 1/2] kconfig: make multiconfig.py compatible with Python 2.4 Masahiro Yamada
2014-08-04 10:23 ` [U-Boot] [RFC PATCH v2 2/2] tools: make genboardscfg.py compatible with Python 2.5 Masahiro Yamada
2014-08-22  6:01   ` Masahiro Yamada
2014-08-22  6:18     ` Masahiro Yamada
2014-08-23 12:44     ` Tom Rini
2014-08-25  1:53       ` Masahiro Yamada
2014-08-04 10:40 ` [U-Boot] [RFC PATCH v2 0/2] Make Python scripts compatible with older versions Simon Glass
2014-08-04 11:21 ` Igor Grinberg [this message]
2014-08-04 12:00   ` Masahiro Yamada
2014-08-04 12:59     ` Masahiro Yamada
2014-08-04 13:17       ` Igor Grinberg
2014-08-04 13:28         ` Masahiro Yamada
2014-08-07 10:57         ` Tom Rini
2014-08-07 13:17           ` Igor Grinberg
2014-08-07 16:57             ` Tom Rini
2014-08-07 17:33               ` Stephen Warren
2014-08-07 17:53                 ` Tom Rini
2014-08-10  8:49                 ` Igor Grinberg
2014-08-10 11:14                   ` Tom Rini
2014-08-11 10:18                     ` Igor Grinberg
2014-08-11 13:12                       ` Tom Rini
2014-08-11 23:03                         ` Masahiro YAMADA
2014-08-12  1:53                           ` Tom Rini
2014-08-18  4:45                             ` Masahiro Yamada
2014-08-11 16:58                   ` Stephen Warren
2014-08-12 10:32                     ` Igor Grinberg
2014-08-04 13:50 ` Tom Rini
2014-08-05  2:05   ` Yan, Miao
2014-08-05 14:18     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DF6CBC.8040701@compulab.co.il \
    --to=grinberg@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox