public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 00/16] sunxi: Allwinner A10/A13/A20 DRAM controller fixes
Date: Tue, 05 Aug 2014 12:00:26 +0200	[thread overview]
Message-ID: <53E0AB3A.7090207@redhat.com> (raw)
In-Reply-To: <1407222120.23472.33.camel@dagon.hellion.org.uk>

Hi,

On 08/05/2014 09:02 AM, Ian Campbell wrote:
> On Sun, 2014-08-03 at 05:32 +0300, Siarhei Siamashka wrote:
>> This is version 2 of
>>     http://lists.denx.de/pipermail/u-boot/2014-July/183981.html
>>
>> Rebased on git://git.denx.de/u-boot-sunxi.git master branch (commit
>> 3340eab26d89176dd0bf543e6d2590665c577423 "sun7i: Add bananapi board")
> 
> This all looks great, thanks!

Indeed, many thanks for working on this and for the rebase.

> I think this should be the primary subject of the next sunxi PR. A
> change of this magnitude really ought to be in an rc1 so hopefully there
> won't be any significant changes required (it doesn't look like there
> should be to me).
> 
> I'm AFK from tomorrow until after when I expect rc1 to be so I'm not
> around to prepare a PR -- Hans can you take care of it (if you agree
> with my assessment of the patches, of course)? I've delegated them to
> you in pw in anticipation.

Ok, I've also reviewed this, and ran some tests, and this looks good,
I agree with trying to get this into RC-1.

But currently we already have a pull-req pending for Albert. So for
now I've pushed this to u-boot-sunxi/next, with u-boot-sunxi/master
still reflecting the pull-req send to Albert.

I guess it is probably best to send a new pull-req to Albert
superseding the old one. Albert how would you prefer to handle this ?

Regards,

Hans


p.s.

Siarhei Siamashka, I've seen your "Single u-boot binary" patches,
and I'll try to review them during the coming days.

      reply	other threads:[~2014-08-05 10:00 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-03  2:32 [U-Boot] [PATCH v2 00/16] sunxi: Allwinner A10/A13/A20 DRAM controller fixes Siarhei Siamashka
2014-08-03  2:32 ` [U-Boot] [PATCH v2 01/16] sunxi: dram: Remove useless 'dramc_scan_dll_para()' function Siarhei Siamashka
2014-08-03  2:32 ` [U-Boot] [PATCH v2 02/16] sunxi: dram: Remove broken super-standby remnants Siarhei Siamashka
2014-08-05  6:37   ` Ian Campbell
2014-08-03  2:32 ` [U-Boot] [PATCH v2 03/16] sunxi: dram: Respect the DDR3 reset timing requirements Siarhei Siamashka
2014-08-05  6:38   ` Ian Campbell
2014-08-03  2:32 ` [U-Boot] [PATCH v2 04/16] sunxi: dram: Fix CKE delay handling for sun4i/sun5i Siarhei Siamashka
2014-08-05  6:41   ` Ian Campbell
2014-08-03  2:32 ` [U-Boot] [PATCH v2 05/16] sunxi: dram: Remove broken impedance and ODT configuration code Siarhei Siamashka
2014-08-05  6:43   ` Ian Campbell
2014-08-03  2:32 ` [U-Boot] [PATCH v2 06/16] sunxi: dram: Do DDR3 reset in the same way on sun4i/sun5i/sun7i Siarhei Siamashka
2014-08-05  6:43   ` Ian Campbell
2014-08-03  2:32 ` [U-Boot] [PATCH v2 07/16] sunxi: dram: Add 'await_bits_clear'/'await_bits_set' helper functions Siarhei Siamashka
2014-08-05  6:44   ` Ian Campbell
2014-08-03  2:32 ` [U-Boot] [PATCH v2 08/16] sunxi: dram: Re-introduce the impedance calibration ond ODT Siarhei Siamashka
2014-08-05  6:47   ` Ian Campbell
2014-08-03  2:32 ` [U-Boot] [PATCH v2 09/16] sunxi: dram: Configurable MBUS clock speed (use PLL5 or PLL6) Siarhei Siamashka
2014-08-05  6:49   ` Ian Campbell
2014-08-03  2:32 ` [U-Boot] [PATCH v2 10/16] sunxi: dram: Use divisor P=1 for PLL5 Siarhei Siamashka
2014-08-03  2:32 ` [U-Boot] [PATCH v2 11/16] sunxi: dram: Improve DQS gate data training error handling Siarhei Siamashka
2014-08-03  2:32 ` [U-Boot] [PATCH v2 12/16] sunxi: dram: Add a helper function 'mctl_get_number_of_lanes' Siarhei Siamashka
2014-08-05  6:50   ` Ian Campbell
2014-08-03  2:32 ` [U-Boot] [PATCH v2 13/16] sunxi: dram: Configurable DQS gating window mode and delay Siarhei Siamashka
2014-08-05  6:53   ` Ian Campbell
2014-08-03  2:32 ` [U-Boot] [PATCH v2 14/16] sunxi: dram: Drop DDR2 support and assume only single rank DDR3 memory Siarhei Siamashka
2014-08-05  6:54   ` Ian Campbell
2014-08-03  2:32 ` [U-Boot] [PATCH v2 15/16] sunxi: dram: Derive write recovery delay from DRAM clock speed Siarhei Siamashka
2014-08-03  2:32 ` [U-Boot] [PATCH v2 16/16] sunxi: dram: Autodetect DDR3 bus width and density Siarhei Siamashka
2014-08-05  7:02 ` [U-Boot] [PATCH v2 00/16] sunxi: Allwinner A10/A13/A20 DRAM controller fixes Ian Campbell
2014-08-05 10:00   ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53E0AB3A.7090207@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox