From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Tue, 05 Aug 2014 10:02:55 -0600
Subject: [U-Boot] [PATCH v3] ARM: tegra: Add support for norrin board
In-Reply-To: <1407189434-29869-1-git-send-email-amartin@nvidia.com>
References: <1407189434-29869-1-git-send-email-amartin@nvidia.com>
Message-ID: <53E1002F.8070304@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 08/04/2014 03:57 PM, Allen Martin wrote:
> Norrin (PM370) is a Tegra124 clamshell board that is very similar to
> venice2, but it has a different panel, the sdcard cd and wp sense are
> flipped, and it has a different revision of the AS3722 PMIC.  This
> board is also refered to as "nyan" in the ChromeOS trees.

> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index e385eda94cdf..f4e0f5a42c14 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -716,6 +716,9 @@ config TARGET_DALMORE
>   config TARGET_JETSON_TK1
>   	bool "Support jetson-tk1"
>
> +config TARGET_NORRIN
> +	bool "Support norrin"
> +

Note that this patch is going to conflict with:
http://patchwork.ozlabs.org/patch/376287/
tegra: kconfig: move board select menu and common settings

... since that moves all the Tegra board options into sub-menus. At some 
point, this or that patch will need to be rebased on the other, or 
merged with each-other

> @@ -912,6 +915,7 @@ source "board/nvidia/cardhu/Kconfig"
>   source "board/nvidia/dalmore/Kconfig"
>   source "board/nvidia/harmony/Kconfig"
>   source "board/nvidia/jetson-tk1/Kconfig"
> +source "board/nvidia/norrin/Kconfig"

Indentation looks wrong there.

> diff --git a/board/nvidia/venice2/as3722_init.h b/board/nvidia/venice2/as3722_init.h

> -#ifdef CONFIG_BOARD_JETSON_TK1
> +#if defined(CONFIG_BOARD_JETSON_TK1) || defined(CONFIG_BOARD_NORRIN)

Let's use CONFIG_TARGET_NORRIN directly here. This is the variable 
that's set up by Kconfig. It means that norrin_defconfig won't have to 
set up the extra/custom CONFIG_BOARD_NORRIN.

I've already sent a patch to fix this same issue for Jetson TK1:

http://patchwork.ozlabs.org/patch/375467/
ARM: tegra: remove custom define for Jetson TK1

> diff --git a/configs/norrin_defconfig b/configs/norrin_defconfig

> +CONFIG_SYS_EXTRA_OPTIONS="BOARD_NORRIN="

Per my comment above, you can remove that one line.

Aside from those issues, this patch looks fine.