[U-Boot] [PATCH v3 4/4] usb/gadget: fastboot: minor cleanup

Steve Rae
2014-08-06T23:34:53Z

On 14-07-30 06:40 PM, Marek Vasut wrote:
> On Thursday, June 26, 2014 at 10:13:24 PM, Steve Rae wrote:
>> - update static function
>> - additional debugging statements
>>
>> Signed-off-by: Steve Rae <srae@broadcom.com>
>> ---
>>
>> Changes in v3: None
>> Changes in v2:
>> - new in v2
>>
>> drivers/usb/gadget/f_fastboot.c | 10 +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/f_fastboot.c
>> b/drivers/usb/gadget/f_fastboot.c index 89c2d3e..3e6e47f 100644
>> --- a/drivers/usb/gadget/f_fastboot.c
>> +++ b/drivers/usb/gadget/f_fastboot.c
>> @@ -293,7 +293,7 @@ static int fastboot_add(struct usb_configuration *c)
>> }
>> DECLARE_GADGET_BIND_CALLBACK(usb_dnl_fastboot, fastboot_add);
>>
>> -int fastboot_tx_write(const char *buffer, unsigned int buffer_size)
>> +static int fastboot_tx_write(const char *buffer, unsigned int buffer_size)
>> {
>> struct usb_request *in_req = fastboot_func->in_req;
>> int ret;
>> @@ -338,6 +338,7 @@ static void cb_getvar(struct usb_ep *ep, struct
>> usb_request *req) strcpy(response, "OKAY");
>> strsep(&cmd, ":");
>> if (!cmd) {
>> + printf("%s: missing var\n", __func__);
>
> I'd spell it out completely -- variable -- but I'm not sure if you might need to
> maintain some kind of compatibility with the fastboot responses here or not.

nope -- done in v4
Thanks, Steve

> [...]
>
> Best regards,
> Marek Vasut
>