public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 20/20] RFC: Deprecate MAKEALL
Date: Mon, 11 Aug 2014 11:23:13 -0700	[thread overview]
Message-ID: <53E90A11.4020006@freescale.com> (raw)
In-Reply-To: <1407619996-3637-21-git-send-email-sjg@chromium.org>

On 08/09/2014 02:33 PM, Simon Glass wrote:
> Since buildman now includes most of the features of MAKEALL it is probably
> time to talk about deprecating MAKEALL.
> 
> Comments welcome.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> 
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2:
> - Add new patch to fix existing typos
> 
>  MAKEALL | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/MAKEALL b/MAKEALL
> index 929fe88..dbbf74b 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -60,6 +60,10 @@ usage()
>  	exit ${ret}
>  }
>  
> +echo "** Note: MAKEALL is deprecated - please use buildman instead"
> +echo "** See tools/buildman/README for details"
> +echo
> +
>  SHORT_OPTS="ha:c:v:s:b:lmMCnr"
>  LONG_OPTS="help,arch:,cpu:,vendor:,soc:,board:,list,maintainers,mails,check,continue,rebuild-errors"
>  
> 
Simon,

This doesn't stop this patch. Just a suggestion.

It may be helpful to print this message at the end of output of MAKEALL. I check
the summary at the end of run carefully, but not paying too much attention at
the beginning. Beside, if I have a lot of output I may miss the beginning.

Another suggestion for future patch is to use return value for buildman. For
now, I have to check if err files are created during building.

York

  reply	other threads:[~2014-08-11 18:23 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-09 21:32 [U-Boot] [PATCH v6 0/20] Add some missing buildman features and deprecate MAKEALL Simon Glass
2014-08-09 21:32 ` [U-Boot] [PATCH v6 01/20] buildman: Fix a few typos Simon Glass
2014-08-09 21:32 ` [U-Boot] [PATCH v6 02/20] buildman: Add some notes about moving from MAKEALL Simon Glass
2014-08-09 21:32 ` [U-Boot] [PATCH v6 03/20] buildman: Allow building of current source tree Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 04/20] buildman: Move BuilderThread code to its own file Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 05/20] buildman: Sort command line options Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 06/20] buildman: Refactor output options Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 07/20] buildman: Add verbose option to display errors as they happen Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 08/20] buildman: Remove unused non-incremental build method code Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 09/20] buildman: Add an option to specify the buildman config file Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 10/20] buildman: Add a message indicating there are no errors Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 11/20] buildman: Add a few more toolchain examples to the README Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 12/20] buildman: Introduce an 'and' operator for board selection Simon Glass
2014-08-11 17:51   ` York Sun
2014-08-09 21:33 ` [U-Boot] [PATCH v6 13/20] buildman: Allow selection of the number of commits to build Simon Glass
2014-08-11 17:51   ` York Sun
2014-08-09 21:33 ` [U-Boot] [PATCH v6 14/20] patman: Move the 'git log' command into a function Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 15/20] patman: Only use git's --no-decorate when available Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 16/20] patman: buildman: Correct spelling of 'colour' Simon Glass
2014-08-09 22:01   ` Fabio Estevam
2014-08-09 22:17     ` Simon Glass
2014-08-09 22:29       ` Fabio Estevam
2014-08-09 22:34         ` Simon Glass
2014-08-10  5:23           ` York Sun
2014-08-11 20:34           ` Tom Rini
2014-08-09 21:33 ` [U-Boot] [PATCH v6 17/20] patman: Fix indentation in terminal.py Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 18/20] patman: Correct unit tests to run correctly Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 19/20] patman: Remove the -a option Simon Glass
2014-08-09 21:33 ` [U-Boot] [PATCH v6 20/20] RFC: Deprecate MAKEALL Simon Glass
2014-08-11 18:23   ` York Sun [this message]
2014-08-12 15:00     ` Simon Glass
2014-08-12 21:05       ` Tom Rini
2014-08-12 22:22         ` Simon Glass
2014-08-12 22:27           ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53E90A11.4020006@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox