From mboxrd@z Thu Jan  1 00:00:00 1970
From: York Sun <yorksun@freescale.com>
Date: Mon, 11 Aug 2014 11:23:13 -0700
Subject: [U-Boot] [PATCH v6 20/20] RFC: Deprecate MAKEALL
In-Reply-To: <1407619996-3637-21-git-send-email-sjg@chromium.org>
References: <1407619996-3637-1-git-send-email-sjg@chromium.org>
	<1407619996-3637-21-git-send-email-sjg@chromium.org>
Message-ID: <53E90A11.4020006@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 08/09/2014 02:33 PM, Simon Glass wrote:
> Since buildman now includes most of the features of MAKEALL it is probably
> time to talk about deprecating MAKEALL.
> 
> Comments welcome.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> 
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2:
> - Add new patch to fix existing typos
> 
>  MAKEALL | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/MAKEALL b/MAKEALL
> index 929fe88..dbbf74b 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -60,6 +60,10 @@ usage()
>  	exit ${ret}
>  }
>  
> +echo "** Note: MAKEALL is deprecated - please use buildman instead"
> +echo "** See tools/buildman/README for details"
> +echo
> +
>  SHORT_OPTS="ha:c:v:s:b:lmMCnr"
>  LONG_OPTS="help,arch:,cpu:,vendor:,soc:,board:,list,maintainers,mails,check,continue,rebuild-errors"
>  
> 
Simon,

This doesn't stop this patch. Just a suggestion.

It may be helpful to print this message at the end of output of MAKEALL. I check
the summary at the end of run carefully, but not paying too much attention at
the beginning. Beside, if I have a lot of output I may miss the beginning.

Another suggestion for future patch is to use return value for buildman. For
now, I have to check if err files are created during building.

York