public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] embest/mx6boards: only toggle eMMC usdhc3 RST line on MarSboard
@ 2014-06-09 22:08 Iain Paton
  2014-08-13  7:35 ` Stefano Babic
  0 siblings, 1 reply; 2+ messages in thread
From: Iain Paton @ 2014-06-09 22:08 UTC (permalink / raw)
  To: u-boot

On MarS usdhc3 is eMMC, on RIoT usdhc3 is uSD and eMMC is usdhc4.

Don't run the MarS specific eMMC reset code on usdhc3 when 
board_type == BOARD_IS_RIOTBOARD

Signed-off-by: Iain Paton <ipaton0@gmail.com>
---
 board/embest/mx6boards/mx6boards.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/board/embest/mx6boards/mx6boards.c b/board/embest/mx6boards/mx6boards.c
index d06b57d..530ea4f 100644
--- a/board/embest/mx6boards/mx6boards.c
+++ b/board/embest/mx6boards/mx6boards.c
@@ -246,6 +246,7 @@ int board_mmc_init(bd_t *bis)
 					riotboard_usdhc3_pads,
 					ARRAY_SIZE(riotboard_usdhc3_pads));
 				gpio_direction_input(USDHC3_CD_GPIO);
+			} else {
 				gpio_direction_output(IMX_GPIO_NR(7, 8) , 0);
 				udelay(250);
 				gpio_set_value(IMX_GPIO_NR(7, 8), 1);
-- 
1.8.5.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] embest/mx6boards: only toggle eMMC usdhc3 RST line on MarSboard
  2014-06-09 22:08 [U-Boot] [PATCH] embest/mx6boards: only toggle eMMC usdhc3 RST line on MarSboard Iain Paton
@ 2014-08-13  7:35 ` Stefano Babic
  0 siblings, 0 replies; 2+ messages in thread
From: Stefano Babic @ 2014-08-13  7:35 UTC (permalink / raw)
  To: u-boot

Hi Ian,

On 10/06/2014 00:08, Iain Paton wrote:
> On MarS usdhc3 is eMMC, on RIoT usdhc3 is uSD and eMMC is usdhc4.
> 
> Don't run the MarS specific eMMC reset code on usdhc3 when 
> board_type == BOARD_IS_RIOTBOARD
> 
> Signed-off-by: Iain Paton <ipaton0@gmail.com>
> ---
>  board/embest/mx6boards/mx6boards.c | 1 +
>  1 file changed, 1 insertion(+)
> 

Digging deeper in patchwork, I found I have not yet applied this old
patch. Sorry for that.

> diff --git a/board/embest/mx6boards/mx6boards.c b/board/embest/mx6boards/mx6boards.c
> index d06b57d..530ea4f 100644
> --- a/board/embest/mx6boards/mx6boards.c
> +++ b/board/embest/mx6boards/mx6boards.c
> @@ -246,6 +246,7 @@ int board_mmc_init(bd_t *bis)
>  					riotboard_usdhc3_pads,
>  					ARRAY_SIZE(riotboard_usdhc3_pads));
>  				gpio_direction_input(USDHC3_CD_GPIO);
> +			} else {
>  				gpio_direction_output(IMX_GPIO_NR(7, 8) , 0);
>  				udelay(250);
>  				gpio_set_value(IMX_GPIO_NR(7, 8), 1);
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-08-13  7:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-09 22:08 [U-Boot] [PATCH] embest/mx6boards: only toggle eMMC usdhc3 RST line on MarSboard Iain Paton
2014-08-13  7:35 ` Stefano Babic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox