From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikita Kiryanov Date: Wed, 13 Aug 2014 13:57:38 +0300 Subject: [U-Boot] [PATCH V3 12/18] arm: mx6: add support for Compulab cm-fx6 CoM In-Reply-To: References: <1407690780-19645-4-git-send-email-nikita@compulab.co.il> <1407774152-6564-1-git-send-email-nikita@compulab.co.il> Message-ID: <53EB44A2.2010104@compulab.co.il> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On 12/08/14 17:48, Simon Glass wrote: > Hi Nikita, > > On 11 August 2014 10:22, Nikita Kiryanov wrote: >> Add initial support for Compulab CM-FX6 CoM. >> Support includes MMC, SPI flash, and SPL with dynamic DRAM detection. >> [..snip..] >> board/compulab/cm_fx6/common.h | 36 ++++ >> board/compulab/cm_fx6/imximage.cfg | 8 + >> board/compulab/cm_fx6/spl.c | 400 +++++++++++++++++++++++++++++++++++++ >> boards.cfg | 2 + >> include/configs/cm_fx6.h | 211 +++++++++++++++++++ > > I think you need Kconfig etc. here? Also we don't use boards.cfg > anymore. I pushed a tree to u-boot-x86.git branch cm_fx6 which hacks > in a few of these things as an example (enough to make it build > anyway). > [..snip..] >> +# >> +ifdef CONFIG_SPL_BUILD >> +obj-y = common.o spl.o >> +else >> +obj-y = common.o cm_fx6.o >> +endif > > Note this doesn't apply or build for me on mainline due to missing > Kconfig stuff. I might be missing a patch. > >> diff --git a/boards.cfg b/boards.cfg >> index e3a0726..308b94e 100644 >> --- a/boards.cfg >> +++ b/boards.cfg >> @@ -334,6 +334,8 @@ Active arm armv7 mx6 freescale mx6sabresd >> Active arm armv7 mx6 freescale mx6slevk mx6slevk mx6slevk:IMX_CONFIG=board/freescale/mx6slevk/imximage.cfg,MX6SL Fabio Estevam >> Active arm armv7 mx6 gateworks gw_ventana gwventana gw_ventana:IMX_CONFIG=board/gateworks/gw_ventana/gw_ventana.cfg,MX6QDL,SPL Tim Harvey >> Active arm armv7 mx6 solidrun hummingboard hummingboard_solo hummingboard:IMX_CONFIG=board/solidrun/hummingboard/solo.cfg,MX6S,DDR_MB=512 Jon Nettleton >> +Active arm armv7 mx6 compulab cm_fx6 cm_fx6 >> +- Nikita Kiryanov >> Active arm armv7 omap3 - overo omap3_overo - Steve Sakoman >> Active arm armv7 omap3 - pandora omap3_pandora - Grazvydas Ignotas >> Active arm armv7 omap3 8dtech eco5pk eco5pk - Raphael Assenat > > We don't use this file anymore. > >> diff --git a/include/configs/cm_fx6.h b/include/configs/cm_fx6.h >> new file mode 100644 [..snip..] >> + >> +/* Machine config */ >> +#define CONFIG_MX6 >> +#define CONFIG_MX6QDL >> +#define CONFIG_CM_FX6 > > Should these three be defined in the Kconfig file instead? What does > CONFIG_CM_FX6 represent? There might be a CONFIG_TARGET_CM_FX6 defined > by Kconfig. > >> +#define CONFIG_SYS_LITTLE_ENDIAN >> +#define CONFIG_MACH_TYPE 4273 >> +#define CONFIG_SYS_HZ 1000 Yes you're correct. I was hoping this would be accepted before all the Kconfig changes took effect but things didn't work out that way. I'll rebase and post a new version. > > Regards, > Simon >