[U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

Tom Rini
2014-08-14T19:38:05Z

On Thu, Aug 14, 2014 at 01:41:16PM -0500, Robert Nelson wrote:
> On Thu, Aug 14, 2014 at 10:49 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> > On 08/14/2014 02:25 AM, Alexander Holler wrote:
> >>
> >> Am 31.07.2014 21:57, schrieb Stephen Warren:
> >>
> >>> Huh, I do see that now. I must have been looking at the content of
> >>> common/cmd_nvedit.c from the wrong branch, which didn't include that
> >>> patch. I could have sworn I checked git history too, but evidently not.
> >>> It is indeed clearly there right before the patches which use it. Sorry
> >>> for the noise.
> >>
> >>
> >> As I've just remembered where I did see your name before, the config for
> >> the rpi (as found in 2004.04) misses the uenvcmd. That's necessary to
> >> execute commands when using uEnv.txt.
> >>
> >> It's easily done with something like the following:
> >>
> >> "env import -t -r $loadaddr $filesize;" \
> >> "if test -n \"$uenvcmd\"; then " \
> >> "echo \"Running uenvcmd ...\";" \
> >> "run uenvcmd;" \
> >> "fi;" \
> >
> >
> > My intention was that uEnv.txt be used to set up environment variables, not
> > to allow its use for custom scripts.
>
> The check for if uenvcmd is set then run uenvcmd syntax, should really
> be pushed into the distro default stuff. As that syntax is used by
> default for a lot of different targets in u-boot. Most users who deal
> with u-boot (even if they don't want to) seem to understand it.

Right. The intention was to provide a "just do what I want you to do"
hook to the end user.

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140814/16790282/attachment.pgp>