[U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

Alexander Holler
2014-08-14T19:59:00Z

Am 14.08.2014 21:51, schrieb Stephen Warren:
> On 08/14/2014 01:38 PM, Alexander Holler wrote:
>> Am 14.08.2014 17:49, schrieb Stephen Warren:
>>> On 08/14/2014 02:25 AM, Alexander Holler wrote:
>>
>>>> As I've just remembered where I did see your name before, the config
>>>> for
>>>> the rpi (as found in 2004.04) misses the uenvcmd. That's necessary to
>>>> execute commands when using uEnv.txt.
>>>>
>>>> It's easily done with something like the following:
>>>>
>>>> "env import -t -r $loadaddr
>>>> $filesize;" \
>>>> "if test -n \"$uenvcmd\"; then " \
>>>> "echo \"Running uenvcmd
>>>> ...\";" \
>>>> "run uenvcmd;" \
>>>> "fi;" \
>>>
>>> My intention was that uEnv.txt be used to set up environment variables,
>>> not to allow its use for custom scripts.
>>>
>>
>> Sure. In most cases changing the predefined available variables is
>> enough. But it's a very hand option if someone wants or needs to do
>> stuff which can't be done by just changing some environment variables
>> (one never knows what ideas people will have).
>
> For such presumably non-standard things, why can't the user simply edit
> $bootcmd, and pre-pend whatever they want?

Depends on when the bootcmd will be constructed. Usually that is done
after having read uEnv.txt to include variables defined in uEnv.txt in
bootcmd. So whatever bootcmd one sets in uEnv.txt, it just will be
overwritten.

Regards,

Alexander Holler