[U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

Alexander Holler
2014-08-14T19:38:47Z

Am 14.08.2014 17:49, schrieb Stephen Warren:
> On 08/14/2014 02:25 AM, Alexander Holler wrote:

>> As I've just remembered where I did see your name before, the config for
>> the rpi (as found in 2004.04) misses the uenvcmd. That's necessary to
>> execute commands when using uEnv.txt.
>>
>> It's easily done with something like the following:
>>
>> "env import -t -r $loadaddr $filesize;" \
>> "if test -n \"$uenvcmd\"; then " \
>> "echo \"Running uenvcmd ...\";" \
>> "run uenvcmd;" \
>> "fi;" \
>
> My intention was that uEnv.txt be used to set up environment variables,
> not to allow its use for custom scripts.
>

Sure. In most cases changing the predefined available variables is
enough. But it's a very hand option if someone wants or needs to do
stuff which can't be done by just changing some environment variables
(one never knows what ideas people will have).

And as it now seems to be possible to write the environment back to disk
too, one should be make sure that uenvcmd will be cleared before writing
the environment back to disk. Personally I prefer to not let the
bootloader write to any (real) filesystem, but just in case someone does
so ...

Regards,

Alexander Holler