U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v7 5/5] RFC: Deprecate MAKEALL
Date: Fri, 15 Aug 2014 09:34:15 -0700	[thread overview]
Message-ID: <53EE3687.50008@freescale.com> (raw)
In-Reply-To: <53EE333B.1070307@wwwdotorg.org>

On 08/15/2014 09:20 AM, Stephen Warren wrote:
> On 08/15/2014 10:13 AM, Simon Glass wrote:
>> Hi Stephen,
>>
>> On 15 August 2014 09:46, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>>
>>> On 08/14/2014 05:35 PM, Simon Glass wrote:
>>>>
>>>> Since buildman now includes most of the features of MAKEALL it is probably
>>>> time to talk about deprecating MAKEALL.
>>>
>>>
>>> I guess I don't care too much, but I would like to point out that when I mentioned the annoyance of having to change my scripts:
>>>
>>> from:
>>> make ARCH=arm jetson_tk1_config
>>>
>>> to:
>>> make ARCH=arm jetson_tk1_defconfig
>>>
>>> ... together with having to detect which version to use since different U-Boot commits required a difference command,  one of the answers was that "MAKEALL jetson_tk1" still worked the same on both old and new git commits, and could be used as a replacement. This patch would invalidate that.
>>
>> Well I suppose you could use:
>>
>>     ./tools/buildman/buildman jetson_tk1
>>
>> to get the same effect.
> 
> True, although that command has been available for a much shorter time 
> than MAKEALL...
> 
> Replacing the MAKEALL script body with a call to buildman might solve 
> that? I'm not sure that buildman puts the build results in the same place.
> 
> But like I said, I'm not too worried about this personally, so there's 
> probably no need to change anything.
> 
I heavily rely on MAKEALL. I have tested buildman recently to confirm it has
most features I need to replace MAKEALL with some command line switches. But I
need to adjust my testing due to some difference

1) The log is different
I can see the err log file, but not the regular log. Buildman runs silently by
default.

2) The return value of buildman doesn't tell if an error happens.
I have to search for err file to identify if any error.

I only tested the features I used most.

York

  reply	other threads:[~2014-08-15 16:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14 23:35 [U-Boot] [PATCH v7 0/5] Add some missing buildman features and deprecate MAKEALL Simon Glass
2014-08-14 23:35 ` [U-Boot] [PATCH v7 1/5] patman: Support the 'reverse' option for 'git log' Simon Glass
2014-08-14 23:35 ` [U-Boot] [PATCH v7 2/5] patman: Fix indentation in terminal.py Simon Glass
2014-08-14 23:35 ` [U-Boot] [PATCH v7 3/5] patman: Correct unit tests to run correctly Simon Glass
2014-08-14 23:35 ` [U-Boot] [PATCH v7 4/5] patman: Remove the -a option Simon Glass
2014-08-14 23:35 ` [U-Boot] [PATCH v7 5/5] RFC: Deprecate MAKEALL Simon Glass
2014-08-15 15:46   ` Stephen Warren
2014-08-15 16:13     ` Simon Glass
2014-08-15 16:20       ` Stephen Warren
2014-08-15 16:34         ` York Sun [this message]
2014-08-23  3:47           ` Simon Glass
2014-08-15 16:45         ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53EE3687.50008@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox