From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] kconfig: convert Kconfig helper script into a shell script
Date: Mon, 18 Aug 2014 10:36:48 -0600 [thread overview]
Message-ID: <53F22BA0.1030403@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ0vP2Rwn0C-6+jhcdQoaJUgqUr02KE6Wg3=c-bzHNBthw@mail.gmail.com>
On 08/18/2014 10:27 AM, Simon Glass wrote:
> Hi,
>
> On 18 August 2014 10:20, Stephen Warren <swarren@wwwdotorg.org
> <mailto:swarren@wwwdotorg.org>> wrote:
>
> On 08/16/2014 10:56 PM, Masahiro Yamada wrote:
>
> Commit 51148790 added scripts/multiconfig.py written in Python 2
> to adjust Kconfig for U-Boot.
>
> It has been hard for Python 3 users because Python 2 and Python 3
> are not compatible with each other.
>
> We are not happy about adding a new host tool dependency
> (in this case, Python version dependency) for the core build
> process.
> After some discussion, we decided to use only basic tools.
>
> The script may get a bit unreadable by shell scripting, but we
> believe
> it is worthwhile.
>
> In addition, this commit revives "<board>_config" target that is
> equivalent to "<board>_defconfig" for backwards compatibility.
> It is annoying to adjust various projects which use U-Boot.
>
>
> Personally, I think this change isn't justified; I see no reason to
> replace the perfectly working existing script. Still, if that's
> what's desired...
>
>
> Agreed, it seems unfortunate - long shell scripts are so much harder to
> work with IMO. Is it really not possible to make code compatible with
> both? Also we have lost the docs at the top of the file I think.
It might well be possible to be compatible with both Python 2 and 3, but
the solution mentioned earlier in the thread was as simple as:
- #!/usr/bin/python
+ #!/usr/bin/python2
That would only fail on systems:
a) Without Python2 (which seems a little unlikely at the moment, and
even if that's the case by default, there's enough Python2 code that
surely a compat package would be available)
b) So old that there is no python2 symlink, just python. I don't know
when python2 was added.
next prev parent reply other threads:[~2014-08-18 16:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-17 4:56 [U-Boot] [PATCH v2] kconfig: convert Kconfig helper script into a shell script Masahiro Yamada
2014-08-18 8:03 ` Igor Grinberg
2014-08-18 16:20 ` Stephen Warren
2014-08-18 16:27 ` Simon Glass
2014-08-18 16:36 ` Stephen Warren [this message]
2014-08-19 3:11 ` Masahiro Yamada
2014-08-19 2:34 ` Masahiro Yamada
2014-08-19 10:56 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F22BA0.1030403@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox