public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [UBOOT RFC PATCH 07/13] usb: gadget: g_dnl: Explicitly set the max packet size in descriptor
Date: Tue, 19 Aug 2014 21:08:00 +0530	[thread overview]
Message-ID: <53F36F58.7060308@ti.com> (raw)
In-Reply-To: <20140818165646.4487059c@amdc2363>



On Monday 18 August 2014 08:26 PM, Lukasz Majewski wrote:
> Hi Kishon,
> 
>>> Explicity set the max packet size in the device descriptor to 0x40
>>> as specified in the device class specification for device firmware
>>> upgrade. Also changed debug to printf to explicitly notify the user
>>> if the device has been enumerated.
> 
> It seems like this patch slipped without my attention ...
> 
> Hence, I'd like to ask why you must hardcode the packet size here?

http://www.usb.org/developers/devclass_docs/usbdfu10.pdf (in section 4.2.1 DFU
Mode Device Descriptor), specifies the bMaxPacketSize0 can be  8,16,32,64. And
the value we get from gadget is 512. So hard coded it.

Thanks
Kishon

  reply	other threads:[~2014-08-19 15:38 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-18 14:28 [U-Boot] [UBOOT RFC PATCH 00/13] DRA7xx: Add DWC3 USB driver and enable DFU Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 01/13] include: linux: preparation for porting dwc3 from linux kernel Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 02/13] usb: gadget: udc-core: Add minimal udc-core " Kishon Vijay Abraham I
2014-08-18 14:36   ` Felipe Balbi
2014-08-19 14:58     ` Kishon Vijay Abraham I
2014-08-19  8:52   ` Lukasz Majewski
2014-08-19 15:11     ` Felipe Balbi
2014-08-19 15:18     ` Kishon Vijay Abraham I
2014-08-19 15:28       ` Felipe Balbi
2014-08-19 15:38         ` Lukasz Majewski
2014-08-19 16:06         ` Kishon Vijay Abraham I
2014-08-20  7:02           ` Lukasz Majewski
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 03/13] ARM: DRA7: Enable clocks for USB OTGSS and USB PHY Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 04/13] usb: dwc3: Add dwc3 driver Kishon Vijay Abraham I
2014-08-18 14:37   ` Felipe Balbi
2014-08-19 15:19     ` Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 05/13] usb: dwc3-omap: Add dwc3 glue driver for OMAP Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 06/13] usb: dwc3: TI PHY: PHY driver for dwc3 in TI platforms Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 07/13] usb: gadget: g_dnl: Explicitly set the max packet size in descriptor Kishon Vijay Abraham I
2014-08-18 14:38   ` Felipe Balbi
2014-08-18 14:49     ` Lukasz Majewski
2014-08-18 14:56     ` Lukasz Majewski
2014-08-19 15:38       ` Kishon Vijay Abraham I [this message]
2014-08-19 15:44         ` Felipe Balbi
2014-08-20  7:34           ` Lukasz Majewski
2014-08-20 16:11             ` Felipe Balbi
2014-08-21  8:00               ` Lukasz Majewski
2014-08-21 13:50                 ` Felipe Balbi
2014-08-20  7:23         ` Lukasz Majewski
2014-08-19 15:34     ` Kishon Vijay Abraham I
2014-08-19 15:39       ` Felipe Balbi
2014-08-19 15:42         ` Kishon Vijay Abraham I
2014-08-19 15:48           ` Felipe Balbi
2014-08-19 15:53             ` Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 08/13] common: cmd_dfu: invoke board_usb_cleanup() for cleaning up Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 09/13] common: cmd_dfu: add an API that takes controller index for handling interrupts Kishon Vijay Abraham I
2014-08-19  8:53   ` Lukasz Majewski
2014-08-19 16:09     ` Kishon Vijay Abraham I
2014-08-20  7:37       ` Lukasz Majewski
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 10/13] board: ti: DRA7: added USB initializtion code Kishon Vijay Abraham I
2014-08-18 14:40   ` Felipe Balbi
2014-08-19 16:13     ` Kishon Vijay Abraham I
2014-08-19 16:26       ` Felipe Balbi
2014-08-22 10:47         ` Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 11/13] commom: usb: implement "__weak" functions to make compiler happy Kishon Vijay Abraham I
2014-08-19  8:28   ` Lukasz Majewski
2014-08-19 16:14     ` Kishon Vijay Abraham I
2014-08-21 17:32       ` Tom Rini
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 12/13] include: configs: Enable DWC3 and DFU in DRA7xx Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 13/13] dwc3: core: Change the bounce buffer size to 4096 Kishon Vijay Abraham I
2014-08-18 14:41   ` Felipe Balbi
2014-08-19 16:15     ` Kishon Vijay Abraham I
2014-08-19 16:27       ` Felipe Balbi
2014-08-22 11:02         ` Kishon Vijay Abraham I
2014-08-22 13:54           ` Felipe Balbi
2014-08-18 15:29 ` [U-Boot] [UBOOT RFC PATCH 00/13] DRA7xx: Add DWC3 USB driver and enable DFU Tom Rini
2014-08-19  8:56 ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F36F58.7060308@ti.com \
    --to=kishon@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox