[U-Boot] [UBOOT RFC PATCH 07/13] usb: gadget: g_dnl: Explicitly set the max packet size in descriptor

Lukasz Majewski
2014-08-18T14:49:17Z

Hi Kishon,

> On Mon, Aug 18, 2014 at 07:58:29PM +0530, Kishon Vijay Abraham I
> wrote:
> > Explicity set the max packet size in the device descriptor to 0x40
> > as specified in the device class specification for device firmware
> > upgrade. Also changed debug to printf to explicitly notify the user
> > if the device has been enumerated.

It seems like this patch has slipped without my attention.

Hence I'd like to ask why do you need to hardcode the 0x40 value?

> >
> > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> > ---
> > drivers/usb/gadget/composite.c | 3 +--
> > drivers/usb/gadget/g_dnl.c | 1 +
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/usb/gadget/composite.c
> > b/drivers/usb/gadget/composite.c index 7bd2562..60ca9a5 100644
> > --- a/drivers/usb/gadget/composite.c
> > +++ b/drivers/usb/gadget/composite.c
> > @@ -331,7 +331,7 @@ static int set_config(struct usb_composite_dev
> > *cdev, } else
> > result = 0;
> >
> > - debug("%s: %s speed config #%d: %s\n", __func__,
> > + printf("%s: %s speed config #%d: %s\n", __func__,
>
> this looks like it's only needed for debugging. No strong feelings
> though
>
> > @@ -987,7 +987,6 @@ static int composite_bind(struct usb_gadget
> > *gadget)
> > memcpy(&cdev->desc, composite->dev,
> > sizeof(struct usb_device_descriptor));
> > - cdev->desc.bMaxPacketSize0 = gadget->ep0->maxpacket;
>
> why are you dropping this line ?
>

--
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group