From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Date: Tue, 19 Aug 2014 21:36:39 +0530 Subject: [U-Boot] [UBOOT RFC PATCH 02/13] usb: gadget: udc-core: Add minimal udc-core from linux kernel In-Reply-To: <20140819152808.GJ16085@saruman.home> References: <1408372115-4570-1-git-send-email-kishon@ti.com> <1408372115-4570-3-git-send-email-kishon@ti.com> <20140819105229.0559147a@amdc2363> <53F36ACC.4050609@ti.com> <20140819152808.GJ16085@saruman.home> Message-ID: <53F3760F.4060609@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday 19 August 2014 08:58 PM, Felipe Balbi wrote: > On Tue, Aug 19, 2014 at 08:48:36PM +0530, Kishon Vijay Abraham I wrote: >> Hi Lukasz, >> >> On Tuesday 19 August 2014 02:22 PM, Lukasz Majewski wrote: >>> Hi Kishon, >>> >>>> In order to support multiple USB device controllers in uboot, >>>> udc-core is needed. >>> >>> Is it? In u-boot at best only one UDC is operational at a time. >> >> I didn't mean operational at the same time. dra7xx has 4 USB >> controllers and we should allow the user to use any USB port for DFU. > > but from u-boot's perspective, that can (should?) be a build-time > choice. That user, certainly, won't need more than one port active for > booting, right ? hmm.. right now I don't think any one needs more than one port. But then without udc core, we have to maintain global variable in gadget.c. Maybe slightly cleaner way is to use udc.. > >>>> udc-core also helps to cleanly link the USB >>>> peripheral driver with the gadget driver. Hence Ported minimal >>>> udc-core from linux kernel. >>> >>> I'd appreciate the exact SHA for this udc-core.c code. And the SHA >>> should be from some already released mainline code (like final 3.16), >>> not any private branch nor linux-next. >> >> We can't have the exact udc-core.c from linux kernel as it deals with >> kernel driver model stuff and vfs which is not needed for kernel. >> Trying to have the exact same code from kernel complicates it. > > what he means is to point to the SHA1 when you originally forked the > code from kernel. Sure udc-core can't be the same, but you based off of > a known commit ID frmo the kernel. Ah ok. The header of the file gives the gives the kernel tag it is forked from. Maybe add that in commit log to? -Kishon >