From: Kishon Vijay Abraham I <kishon@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [UBOOT RFC PATCH 11/13] commom: usb: implement "__weak" functions to make compiler happy
Date: Tue, 19 Aug 2014 21:44:20 +0530 [thread overview]
Message-ID: <53F377DC.8060906@ti.com> (raw)
In-Reply-To: <20140819102811.1926b36b@amdc2363>
On Tuesday 19 August 2014 01:58 PM, Lukasz Majewski wrote:
> Hi Kishon,
>
>> Implemented __weak functions for board_usb_cleanup,
>> board_usb_gadget_handle_interrupts and usb_gadget_handle_interrupts
>> to get of compiler errors in platforms that haven't implemented
>> these functions.
>>
>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>> ---
>> common/usb.c | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/common/usb.c b/common/usb.c
>> index 60daa10..892bf7c 100644
>> --- a/common/usb.c
>> +++ b/common/usb.c
>> @@ -1072,4 +1072,22 @@ int board_usb_init(int index, enum
>> usb_init_type init) {
>> return 0;
>> }
>> +
>> +__weak
>> +int board_usb_cleanup(int index, enum usb_init_type init)
>> +{
>> + return 0;
>> +}
>
> This needed before [PATCH 7/13]. Without it your code will cause u-boot
> repository to not be bisectable.
hmm. ok
-Kishon
>
>> +
>> +__weak
>> +int board_usb_gadget_handle_interrupts(int index)
>> +{
>> + return 0;
>> +}
>> +
>> +__weak
>> +int usb_gadget_handle_interrupts(void)
>> +{
>> + return 0;
>> +}
>> /* EOF */
>
>
>
next prev parent reply other threads:[~2014-08-19 16:14 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 14:28 [U-Boot] [UBOOT RFC PATCH 00/13] DRA7xx: Add DWC3 USB driver and enable DFU Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 01/13] include: linux: preparation for porting dwc3 from linux kernel Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 02/13] usb: gadget: udc-core: Add minimal udc-core " Kishon Vijay Abraham I
2014-08-18 14:36 ` Felipe Balbi
2014-08-19 14:58 ` Kishon Vijay Abraham I
2014-08-19 8:52 ` Lukasz Majewski
2014-08-19 15:11 ` Felipe Balbi
2014-08-19 15:18 ` Kishon Vijay Abraham I
2014-08-19 15:28 ` Felipe Balbi
2014-08-19 15:38 ` Lukasz Majewski
2014-08-19 16:06 ` Kishon Vijay Abraham I
2014-08-20 7:02 ` Lukasz Majewski
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 03/13] ARM: DRA7: Enable clocks for USB OTGSS and USB PHY Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 04/13] usb: dwc3: Add dwc3 driver Kishon Vijay Abraham I
2014-08-18 14:37 ` Felipe Balbi
2014-08-19 15:19 ` Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 05/13] usb: dwc3-omap: Add dwc3 glue driver for OMAP Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 06/13] usb: dwc3: TI PHY: PHY driver for dwc3 in TI platforms Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 07/13] usb: gadget: g_dnl: Explicitly set the max packet size in descriptor Kishon Vijay Abraham I
2014-08-18 14:38 ` Felipe Balbi
2014-08-18 14:49 ` Lukasz Majewski
2014-08-18 14:56 ` Lukasz Majewski
2014-08-19 15:38 ` Kishon Vijay Abraham I
2014-08-19 15:44 ` Felipe Balbi
2014-08-20 7:34 ` Lukasz Majewski
2014-08-20 16:11 ` Felipe Balbi
2014-08-21 8:00 ` Lukasz Majewski
2014-08-21 13:50 ` Felipe Balbi
2014-08-20 7:23 ` Lukasz Majewski
2014-08-19 15:34 ` Kishon Vijay Abraham I
2014-08-19 15:39 ` Felipe Balbi
2014-08-19 15:42 ` Kishon Vijay Abraham I
2014-08-19 15:48 ` Felipe Balbi
2014-08-19 15:53 ` Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 08/13] common: cmd_dfu: invoke board_usb_cleanup() for cleaning up Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 09/13] common: cmd_dfu: add an API that takes controller index for handling interrupts Kishon Vijay Abraham I
2014-08-19 8:53 ` Lukasz Majewski
2014-08-19 16:09 ` Kishon Vijay Abraham I
2014-08-20 7:37 ` Lukasz Majewski
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 10/13] board: ti: DRA7: added USB initializtion code Kishon Vijay Abraham I
2014-08-18 14:40 ` Felipe Balbi
2014-08-19 16:13 ` Kishon Vijay Abraham I
2014-08-19 16:26 ` Felipe Balbi
2014-08-22 10:47 ` Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 11/13] commom: usb: implement "__weak" functions to make compiler happy Kishon Vijay Abraham I
2014-08-19 8:28 ` Lukasz Majewski
2014-08-19 16:14 ` Kishon Vijay Abraham I [this message]
2014-08-21 17:32 ` Tom Rini
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 12/13] include: configs: Enable DWC3 and DFU in DRA7xx Kishon Vijay Abraham I
2014-08-18 14:28 ` [U-Boot] [UBOOT RFC PATCH 13/13] dwc3: core: Change the bounce buffer size to 4096 Kishon Vijay Abraham I
2014-08-18 14:41 ` Felipe Balbi
2014-08-19 16:15 ` Kishon Vijay Abraham I
2014-08-19 16:27 ` Felipe Balbi
2014-08-22 11:02 ` Kishon Vijay Abraham I
2014-08-22 13:54 ` Felipe Balbi
2014-08-18 15:29 ` [U-Boot] [UBOOT RFC PATCH 00/13] DRA7xx: Add DWC3 USB driver and enable DFU Tom Rini
2014-08-19 8:56 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F377DC.8060906@ti.com \
--to=kishon@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox