From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 19 Aug 2014 15:42:16 -0600 Subject: [U-Boot] [PATCH] arm: tegra: initial support for apalis t30 In-Reply-To: References: <74725faaf1af8f3d1791693634e69f5ba1eb9f38.1408403674.git.marcel@ziswiler.com> Message-ID: <53F3C4B8.40805@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/18/2014 05:22 PM, Marcel Ziswiler wrote: > This patch adds board support for the Toradex Apalis T30 a computer on > module which can be used on different carrier boards. > > For the sake of ease of use we do not distinguish between different > carrier boards for now as the base module features are deemed > sufficient enough for regular booting. > > The following functionality is working so far: > - eMMC boot and environment storage > - MMC/SD cards (both 8-bit as well as 4-bit slot) > - Network (via external ASIX USB) > - USB client/host (dual role port as client, other two ports as host) At a quick glance this looks OK, Acked-by: Stephen Warren One very minor nit: > diff --git a/arch/arm/dts/tegra30-apalis.dts b/arch/arm/dts/tegra30-apalis.dts > + /* GEN1_I2C: I2C1_SDA/SCL on MXM3 pin 209/211 (e.g. RTC on carrier > + board) */ That comment style is odd. It should be: /* * Text here * More here */