From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Wed, 20 Aug 2014 12:51:09 +0200 Subject: [U-Boot] [PATCH 02/11] imx: ventana: added cputype env var In-Reply-To: References: <1407476151-5603-1-git-send-email-tharvey@gateworks.com> <1407476151-5603-3-git-send-email-tharvey@gateworks.com> <53ECD475.20800@denx.de> Message-ID: <53F47D9D.8070803@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tim, On 18/08/2014 15:52, Tim Harvey wrote: > On Thu, Aug 14, 2014 at 8:23 AM, Stefano Babic wrote: >> On 08/08/2014 07:35, Tim Harvey wrote: >>> There are many similarities between the IMX6QUAD/IMX6DUAL and there are >>> many similarities between the IMX6SOLO/IMX6DUALITE. Add a 'soctype' env >>> variable that tells you which type you have. >>> >>> Signed-off-by: Tim Harvey >>> --- >>> board/gateworks/gw_ventana/gw_ventana.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/board/gateworks/gw_ventana/gw_ventana.c b/board/gateworks/gw_ventana/gw_ventana.c >>> index a8fcb5d..de2336e 100644 >>> --- a/board/gateworks/gw_ventana/gw_ventana.c >>> +++ b/board/gateworks/gw_ventana/gw_ventana.c >>> @@ -1264,6 +1264,7 @@ int misc_init_r(void) >>> else if (is_cpu_type(MXC_CPU_MX6DL) || >>> is_cpu_type(MXC_CPU_MX6SOLO)) >>> cputype = "imx6dl"; >>> + setenv("soctype", cputype); >> >> So you have soc=mx6 and soctype=, if CONFIG_SYS_SOC is >> set. >> >> Is it important to have both or you can simply redefine the variable "soc" ? >> >> Best regards, >> Stefano Babic >> > > Hi Stefano, > > Yes, I do feel its important, although the name and where its set is debatable. > > There are enough similarities between an IMX6DUAL/IMX6QUAD vs an > IMX6SOLO/IMX6DUALLITE making it such that if your board supports all 4 > CPU's, you would usually have just two device-tree files: > imx6q-.dtb (supporting both the QUAD and the DUAL soc variants) > and imx6dl-.dtb (supporting both the DUALLITE and SOLO soc > variants). I agree on that, my only concern if the variable "soc" set to "mx6" has still a meaning. When "soctype" is set to "imx6dl" (or whatever), "soc" loses its meaning. Then it could be possible to set "soc" to the value of cputype instead of adding a new one. What do you think ?= Anyway, this is *not* a blocking point on my side. I will apply the patch as it is if you think it is better for your board. Best regards, Stefano Babic > > Regards, > > Tim > -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================