From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikita Kiryanov Date: Wed, 20 Aug 2014 14:23:15 +0300 Subject: [U-Boot] [PATCH V3 12/18] arm: mx6: add support for Compulab cm-fx6 CoM In-Reply-To: <53EB6038.4050408@compulab.co.il> References: <1407690780-19645-4-git-send-email-nikita@compulab.co.il> <1407774152-6564-1-git-send-email-nikita@compulab.co.il> <53EB6038.4050408@compulab.co.il> Message-ID: <53F48523.2060403@compulab.co.il> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Forgot to answer this part: On 13/08/14 15:55, Igor Grinberg wrote: > Hi Nikita, [...] >> +} >> +#else >> +static void cm_fx6_setup_ecspi(void) { } >> +#endif >> + >> +void board_init_f(ulong dummy) >> +{ >> + gd = &gdata; >> + enable_usdhc_clk(1, 2); > > can this be done inside board_mmc_init() or even in a common location > like fsl_esdhc_initialize()? This is actually here for DMA, not MMC. usdhc3_clk_root is a clock source for APBH DMA, and I have to make sure it is activated or else DMA init will hang when booting from SPI flash (when booting from MMC, the boot rom takes care of turning this clock on). I'll move it to the NAND patch.