From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/9] net: rtl8169: Use non-cached memory if available
Date: Wed, 20 Aug 2014 13:33:06 -0600 [thread overview]
Message-ID: <53F4F7F2.1020204@wwwdotorg.org> (raw)
In-Reply-To: <1408348852-30894-9-git-send-email-thierry.reding@gmail.com>
On 08/18/2014 02:00 AM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> To work around potential issues with explicit cache maintenance of the
> RX and TX descriptor rings, allocate them from a pool of uncached memory
> if the architecture supports it.
> diff --git a/drivers/net/rtl8169.c b/drivers/net/rtl8169.c
> +#ifndef CONFIG_SYS_NONCACHED_MEMORY
> /* Define the TX Descriptor */
> DEFINE_ALIGN_BUFFER(struct TxDesc, tx_ring, NUM_TX_DESC, RTL8169_ALIGN);
>
> /* Define the RX Descriptor */
> DEFINE_ALIGN_BUFFER(struct RxDesc, rx_ring, NUM_RX_DESC, RTL8169_ALIGN);
> +#endif
It feels slightly inconsistent to have one case allocate this memory in
BSS at compile-time, and in the other to allocate it dynamically.
Would it be better to remove this global, and simply call different APIs
(regular aligned malloc, v.s. non-cached allocate) during rtl_init()?
next prev parent reply other threads:[~2014-08-20 19:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 8:00 [U-Boot] [PATCH 0/9] net: rtl8169: Fix cache maintenance issues Thierry Reding
2014-08-18 8:00 ` [U-Boot] [PATCH 1/9] ARM: cache_v7: Various minor cleanups Thierry Reding
2014-08-18 8:00 ` [U-Boot] [PATCH 2/9] ARM: cache-cp15: Use unsigned long for address and size Thierry Reding
2014-08-20 19:15 ` Stephen Warren
2014-08-22 8:29 ` Thierry Reding
2014-08-18 8:00 ` [U-Boot] [PATCH 3/9] malloc: Output region when debugging Thierry Reding
2014-08-18 8:00 ` [U-Boot] [PATCH 4/9] ARM: Implement non-cached memory support Thierry Reding
2014-08-20 19:23 ` Stephen Warren
2014-08-21 15:31 ` Thierry Reding
2014-08-22 8:31 ` Thierry Reding
2014-08-18 8:00 ` [U-Boot] [PATCH 5/9] ARM: tegra: Enable non-cached memory Thierry Reding
2014-08-20 19:24 ` Stephen Warren
2014-08-18 8:00 ` [U-Boot] [PATCH 6/9] net: rtl8169: Honor CONFIG_SYS_RX_ETH_BUFFER Thierry Reding
2014-08-18 8:00 ` [U-Boot] [PATCH 7/9] net: rtl8169: Properly align buffers Thierry Reding
2014-08-20 19:29 ` Stephen Warren
2014-08-22 9:15 ` Thierry Reding
2014-11-12 16:23 ` Simon Glass
2014-11-12 23:38 ` Nobuhiro Iwamatsu
2014-11-13 1:22 ` Simon Glass
2014-08-18 8:00 ` [U-Boot] [PATCH 8/9] net: rtl8169: Use non-cached memory if available Thierry Reding
2014-08-20 19:33 ` Stephen Warren [this message]
2014-08-22 9:29 ` Thierry Reding
2014-08-18 8:00 ` [U-Boot] [PATCH 9/9] net: rtl8169: Add support for RTL-8168/8111g Thierry Reding
2014-08-20 19:12 ` [U-Boot] [PATCH 0/9] net: rtl8169: Fix cache maintenance issues Stephen Warren
2014-08-21 14:11 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F4F7F2.1020204@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox